Draft: Optional CMake target dependencies

Convert target dependencies to cmake generator expressions. If a downstream project does not find a dependency, the generator expression will generate an empty string. If the dependency is found, the generator expression will fill the corresponding dependencies for that target. This has the effect to make dependencies optional from the point of view of the upstream module. Notice that these generator expressions include the corresponding compiler definitions, thus, removing most of the #define problems we have with #234 (closed).

Note: this is an experiment and is not yet fully tested!

cmake/modules/AddBLASLapackFlags.cmake

@@ -24,26 +24,35 @@ set_package_properties("LAPACK" PROPERTIES
 set(HAVE_BLAS ${BLAS_FOUND})
 set(HAVE_LAPACK ${LAPACK_FOUND})
 
-# register Lapack library as dune package
-if(HAVE_LAPACK)
-  dune_register_package_flags(LIBRARIES "${LAPACK_LIBRARIES}")
-
+unset(LAPACK_COMPILE_OPTIONS_FLAGS)
+  if(HAVE_LAPACK)
+    set(LAPACK_COMPILE_OPTIONS_FLAGS "-DHAVE_LAPACK=1")
+  endif()
   include(CMakePushCheckState)
   cmake_push_check_state()
   set(CMAKE_REQUIRED_LIBRARIES ${LAPACK_LIBRARIES})
   check_function_exists("dsyev_" LAPACK_NEEDS_UNDERLINE)
   cmake_pop_check_state()
-elseif(HAVE_BLAS)
-  dune_register_package_flags(LIBRARIES "${BLAS_LIBRARIES}")
+  if(LAPACK_NEEDS_UNDERLINE)
+  list(APPEND LAPACK_COMPILE_OPTIONS_FLAGS "-DLAPACK_NEEDS_UNDERLINE")
 endif()
 
+# register Lapack library as dune package
+dune_register_package_flags(
+  LIBRARIES           "$<$<BOOL:${LAPACK_FOUND}>:${LAPACK_LIBRARIES}>"
+  COMPILE_OPTIONS     "$<$<BOOL:${LAPACK_FOUND}>:${LAPACK_COMPILE_OPTIONS_FLAGS}>")
+
+dune_register_package_flags(
+  LIBRARIES           "$<$<BOOL:${BLAS_FOUND}>:${BLAS_LIBRARIES}>"
+  COMPILE_DEFINITIONS $<$<BOOL:${BLAS_FOUND}>:HAVE_BLAS=1>)
+
 # add function to link against the BLAS/Lapack library
 function(add_dune_blas_lapack_flags _targets)
   foreach(_target ${_targets})
-    if(LAPACK_FOUND)
-      target_link_libraries(${_target} PUBLIC ${LAPACK_LIBRARIES})
-    elseif(BLAS_FOUND)
-      target_link_libraries(${_target} PUBLIC ${BLAS_LIBRARIES})
-    endif()
-  endforeach(_target)
+    target_link_libraries(${_target}      PUBLIC "$<$<BOOL:${LAPACK_FOUND}>:${LAPACK_LIBRARIES}>")
+    target_compile_options(${_target}     PUBLIC "$<$<BOOL:${LAPACK_FOUND}>:${LAPACK_COMPILE_OPTIONS_FLAGS}>")
+
+    target_link_libraries(${_target}      PUBLIC "$<$<BOOL:${BLAS_FOUND}>:${BLAS_LIBRARIES}>")
+    target_compile_definitions(${_target} PUBLIC $<$<BOOL:${BLAS_FOUND}>:HAVE_BLAS=1>)
+  endforeach()
 endfunction(add_dune_blas_lapack_flags)