Draft: Add generated/ subdir to PROJECT_BINARY_DIR where dune-instance can put their generated files
1 unresolved thread
Summary
It is not a good practice to include the full PROJECT_BINARY_DIR
. This is currently necessary, since we generate file with dune-instance utilities in this directory, and also the config.h
file is put into the binary-dir. While the issue with the config files is worked on, this MR moves all generated files into a subdirectory PROJECT_BINARY_DIR/generate
to be included separately. Later we can remove the include of the base binary dir.
Merge request reports
Activity
added buildsystem label
mentioned in merge request !1262 (merged)
- Resolved by Simon Praetorius
114 114 include_directories("${PROJECT_SOURCE_DIR}") 115 115 include_directories("${CMAKE_CURRENT_BINARY_DIR}") 116 116 include_directories("${CMAKE_CURRENT_SOURCE_DIR}") 117 include_directories("${CMAKE_CURRENT_BINARY_DIR}/generated") My only concern is that this is yet another thing to teach people when solving #332 (closed). But this would only be a concern if we choose option (i) from #332 (closed).
mentioned in merge request !1355 (merged)
Please register or sign in to reply