Skip to content
Snippets Groups Projects

Draft: Add generated/ subdir to PROJECT_BINARY_DIR where dune-instance can put their generated files

Open Simon Praetorius requested to merge feature/cmake-add-builddir-generated into master
1 unresolved thread

Summary

It is not a good practice to include the full PROJECT_BINARY_DIR. This is currently necessary, since we generate file with dune-instance utilities in this directory, and also the config.h file is put into the binary-dir. While the issue with the config files is worked on, this MR moves all generated files into a subdirectory PROJECT_BINARY_DIR/generate to be included separately. Later we can remove the include of the base binary dir.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 114 114 include_directories("${PROJECT_SOURCE_DIR}")
    115 115 include_directories("${CMAKE_CURRENT_BINARY_DIR}")
    116 116 include_directories("${CMAKE_CURRENT_SOURCE_DIR}")
    117 include_directories("${CMAKE_CURRENT_BINARY_DIR}/generated")
  • This was just an experiment. Will be closed since it makes the handling of include directories not easier.

  • Simon Praetorius mentioned in merge request !1355 (merged)

    mentioned in merge request !1355 (merged)

  • reopened

  • Please register or sign in to reply
    Loading