[python] Allow to pass optional pythonName to algorithm.load()

The used downstream generator uses an argument pythonName which seems to be only used in logging output. So far dune.generator.algorithm.load() always passes the function signature as pythonName.

When jit-compiling functions with many arguments and complicated type names, this may provide very verbose output. On the other hand, it's very well possible that in many instances of generated functions the signature coincides, while the significant difference is in the actual function body rending the verbose output useless.

This patch adds support for passing a custom value for pythonName to dune.generator.algorithm.load() by a corresponding keyword argument. If the argument is not passed, the signature is used as before.

assigned to @andreas.dedner

@andreas.dedner As far as I can see, this should be perfectly backward compatible. But I cannot oversee, if this approach fits into the general framework, please have a look.

Good idea

The downstream system test does not cover dune-fem. Does this need extra testing?

It actually does. But the automatic test in dune-common with downstream modules only covers the core modules. See !1203 (merged) for a proposal to run (manually) also a full-system test.

At least the (lowercase) downstream system-test and (uppercase) Downstream Dune Nightly Test run here do not cover it.

The linked MR description only mentions that it make the system-test manually startable, not that it extends them. So there are two kinds of system-test: The one executed in the pipeline (no dune-fem) and the one referred to in !1203 (merged) (with dune-fem)?

The name "system-test" in the gitlab-ci.yml file is indeed a bit misleading. This is also changed in !1203 (merged). There it is renamed into core-module-test.

The current situation is that on every commit to dune-common a pipeline in https://gitlab.dune-project.org/infrastructure/dune-nightly-test is triggered. In order not to run always 100 jobs, a reduced pipeline (branch) is defined, that only runs the jobs in a few configurations on all core modules. Because this is in the same repository, GitLab names the test also "Downstream Dune Nightly Test".

The MR !1203 (merged) was actually just an example of how we could improve the current situation and yes, the MR description is not good. This is also, because there was not yet a clear decision on how to improve the gitlab-ci pipeline.

What I wanted to say: Currently a "downstream system test" that includes dune-fem must be triggered manually, by running a pipeline in https://gitlab.dune-project.org/infrastructure/dune-nightly-test with the variable CI_BUILD_REF_NAME set to the branch that you want to test.

There is also another system test especially designed for testing python stuff on GitHub, but I don't know how to trigger this. This is independent of all the nightly/system tests we have here in our GitLab.

The manually triggered full-system test seems to be fine. While the pipeline did not pass as a whole, there seem to be no problems related to this MR.

@santiago.ospina ... but for all configurations dune-pdelab currently fails to compile.

Where should I put the (really simple) instructions on how to run the github tests?

• Open the actions tab for the github project https://github.com/dune-project/dune-testpypi and go the testings scenarios workflow. Here is a direct link https://github.com/dune-project/dune-testpypi/actions/workflows/testing.yml
• Above the list of recent workflows on the right click on the drop down selection Run workflow. The most (only) relevant field is core modules tag which can be a tag or a branch as shown in the examples, it defaults to master. Enter the branch you want to run the tests on here. The concept is the same as for the tests on gitlab, i.e., if the branch exists in a core module it will be used otherwise master is used.
• Press the green button run workflow at the bottom.
• Look at the results once they are done (<90min)

Works: https://github.com/dune-project/dune-testpypi/actions/runs/8123062599

Thanks for the explanations. Unfortunately there's no Run workflow drop down menu for me.

Although you're logged in? Perhaps you have to be a member of the project - what is your github account name?

@santiago.ospina ... but for all configurations dune-pdelab currently fails to compile.

See pdelab/dune-pdelab!613 (merged) (I cannot merge there)

Although you're logged in?

Yes.

Perhaps you have to be a member of the project - what is your github account name?

My github account is cgraeser.

approved this merge request

resolved all threads

merged

mentioned in commit 64735bfb