[Python] add Python bindings for tuplevector

This MR add python bindings for TupleVector.

To get it nicely working i had to access the underlying std::tuple type, from my registerTupleVector function. Therefore, I had to add it as a friend, which I'm not so happy about. @simon.praetorius You also had a similar MR !1357 (closed). @andreas.dedner again can you have a look? @christi I decided to first add the bindings here, which can then be reused in dune-istl hopefully.

assigned to @alexander.mueller

added 1 commit

• 991c8250 - add Python bindings for tuplevector

Compare with previous version

added 1 commit

• fcff97ba - add Python bindings for tuplevector

Compare with previous version

added 1 commit

• fffc1a9c - add Python bindings for tuplevector

Compare with previous version

I don't like that this requires to modify the C++ class. Can you elaborate why exactly you need the fried declaration? Since std::tuple is deliberately a public base class, everything should be available. The only thing that TupleVector does is adding syntactic candy.

added 1 commit

• 7981269c - add Python bindings for tuplevector

Compare with previous version

added 1 commit

• efef930b - add Python bindings for tuplevector

Compare with previous version

added 1 commit

• b5211ce5 - add Python bindings for tuplevector

Compare with previous version

added 1 commit

• 56614143 - add Python bindings for tuplevector

Compare with previous version

added 1 commit

• dec2f4fc - add Python bindings for tuplevector

Compare with previous version

added 1 commit

• eb9fdc3d - add Python bindings for tuplevector

Compare with previous version

added 1 commit

• 0fe4b4dd - add Python bindings for tuplevector

Compare with previous version

marked this merge request as ready

added 1 commit

• ff94085a - add Python bindings for tuplevector

Compare with previous version

added 1 commit

• 8fc87771 - add Python bindings for tuplevector

Compare with previous version

added 1 commit

• 1ba2670a - add Python bindings for tuplevector

Compare with previous version

added 1 commit

• 10c1ad68 - add Python bindings for tuplevector

Compare with previous version

changed title from add Python bindings for tuplevector to [Python] add Python bindings for tuplevector

So basically I think this can be considered mergeable. What do you think @carsten.graeser @andreas.dedner ?

Fine with me to merge this. As I already said, I don't know much about this class or how it is supposed to be used on the Python side, so can't really say if this is the right way to export it. Sometimes that will only become clear through usage in Python and then the bindings might need to be revisited.

I rebased it onto the current master. I will directly work with this an will report possible issues. If the CI suceeds I would be in favor of merging.

added 23 commits

• 10c1ad68...7eea319e - 22 commits from branch master
• b36ed487 - add Python bindings for tuplevector

Compare with previous version

added 28 commits

• b36ed487...53305824 - 27 commits from branch master
• 1fde3ab7 - add Python bindings for tuplevector

Compare with previous version

Is there anything I can do to get this merged? The downstream test are not started. Can anybody start them?

Please document this change in the commit message.

I added it to the commit message. I dont know if this is like you wanted it to be. I also did a small changelog change.

@carsten.graeser happy for this to be merge now?

Sure.

Thanks to both of you!

added 4 commits

• 252a3b4e...847a62c8 - 3 commits from branch master
• 3c31e883 - add Python bindings for tuplevector

Compare with previous version

added 3 commits

• 3c31e883...60580459 - 2 commits from branch master
• ced1c1ef - add Python bindings for tuplevector

Compare with previous version

merged

mentioned in commit 52eaab16