Skip to content
Snippets Groups Projects

[bugfix][dunecontrol] Deal with whitespaces in path names properly.

Merged [bugfix][dunecontrol] Deal with whitespaces in path names properly.
bugfix/dunecontrol into master
1 unresolved thread
Merged Robert K requested to merge bugfix/dunecontrol into master
1 unresolved thread

This fixes some of the issues in #365 (closed). Needs more input from someone else.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
bin/dunecontrol
222 222 fi
223 223 if test "x$DUNE_OPTS_FILE" != "x"; then
224 224 if test "$command" = "configure"; then
225 CMAKE_FLAGS="$(. $DUNE_OPTS_FILE; eval echo \$CMAKE_FLAGS)"
225 CMAKE_FLAGS="$(. "${DUNE_OPTS_FILE}"; eval echo \$CMAKE_FLAGS)"
226 226 CMAKE_FLAGS="$CMAKE_FLAGS -DDUNE_OPTS_FILE=$DUNE_OPTS_FILE"
  • Santiago Ospina De Los Ríos
    Santiago Ospina De Los Ríos @santiago.ospina ·
    Owner

    It looks good. I would just make sure to run all the pipelines before hitting merge, just to be sure (this is used by all of them).

  • Robert K added 1 commit

    added 1 commit

    • d3c8707d - [bugfix][dunecontrol] Deal with whitespaces in path names properly.

    Compare with previous version

  • Robert K marked this merge request as ready

    marked this merge request as ready

  • Robert K enabled an automatic merge when the pipeline for d3c8707d succeeds

    enabled an automatic merge when the pipeline for d3c8707d succeeds

  • Robert K
    Robert K @robert.kloefkorn ·
    Author Owner

    Fixes #365 (closed).

  • Robert K merged

    merged

  • Robert K mentioned in commit b4981225

    mentioned in commit b4981225

  • Simon Praetorius mentioned in issue #365 (closed)

    mentioned in issue #365 (closed)

    • Please register or sign in to reply