Use Hybrid::equal_to instead of Hybrid::equals

From #371 (closed) we get that we want to move to use Hybrid::equal_to instead of Hybrid::equals. To give some slack for people to move, we first introduce Hybrid::equal_to in %DUNE 2.10.0 and later will deprecate Hybrid::equals in %DUNE 2.11.0.

Closes #371 (closed)

changed milestone to %DUNE 2.10.0

requested review from @simon.praetorius

assigned to @santiago.ospina

added 1 commit

• 7d3b6eae - Deprecate Hybrid::equals

Compare with previous version

changed milestone to %DUNE 2.11.0

@simon.praetorius If this is the way to go I was thinking that we could already introduce equals_to in %DUNE 2.10.0, and leave the deprecation of equals to %DUNE 2.11.0.

changed title from Deprecate Hybrid::equals in favor of Hybrid::equal_to to Use Hybrid::equal_to instead of Hybrid::equals

changed milestone to %DUNE 2.10.0

changed the description

added 1 commit

• 195c71c1 - Remove deprecation of Hybrid::equals

Compare with previous version

resolved all threads

approved this merge request

changed the description

added 14 commits

• 195c71c1...3fd176b8 - 13 commits from branch master
• b66fe020 - Add Hybrid::equal_to in favor of Hybrid::equals

Compare with previous version

I like the renaming. What's the reason for not deprecating equals in 2.10 already?

Deprecation directly before the release would mean that there are probably places in the dune modules where this is still used and thus we ship code with warnings. But this is just a guess and not tested.

Hybrid::equals is relatively "old" and might be in more places than just the core modules. We just noticed this too late.

I don't think it's to late. For the release we should only consider core and staging, because we cannot control all downstream uses. That's what the deprecation is for. Except for Dune::Hybrid itself and its tests in dune-common I can find two uses, one in dune-typetree and one in dune-functions. These should be easy to fix now.

ok, lets make a three step procedure. We merge this MR now. Then we can open MRs in dune-typetree and dune-functions to change these two lines. Then we add the deprecation here.

See staging/dune-functions!486 (merged) and staging/dune-typetree!136 (merged)

added 1 commit

• 780cbdc6 - Remove incorrect deprecation in doxygen

Compare with previous version

resolved all threads