Skip to content
Snippets Groups Projects

Replace integerSequenceEntry by get

Merged Simon Praetorius requested to merge issue/deprecate-integer-sequence-entry into master
All threads resolved!

The utility Dune::integerSequenceEntry and Dune::IntegerSequenceEntry are outdated and should be replaced by Dune::get(std::integer_sequence<...>, index) or Dune::get<index>(std::integer_sequence<...>). I have found only one location where it is used. This is fixed already. Note that the class Dune::integerSequenceEntry is not yet properly replaced, but the Dune::get utility from integersequence.hh would also return an std::integral_constant and thus could be used as replacement.

The old implementation integerSequenceEntry was by recursion over the index. This could be very time consuming, but on the other hand it could be statically cached by the compiler. So, it is not clear whether this would give a compile-time performance improvement, but at least, the instantiation depth is drastically reduced by the implementation of Dune::get, which uses an array internally.

Edited by Simon Praetorius

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Simon Praetorius requested review from @christi

    requested review from @christi

  • Simon Praetorius marked this merge request as ready

    marked this merge request as ready

  • added 1 commit

    Compare with previous version

  • Simon Praetorius added 70 commits

    added 70 commits

    Compare with previous version

  • Simon Praetorius resolved all threads

    resolved all threads

  • Simon Praetorius added 23 commits

    added 23 commits

    Compare with previous version

  • Simon Praetorius added 24 commits

    added 24 commits

    Compare with previous version

  • Simon Praetorius added 10 commits

    added 10 commits

    Compare with previous version

  • Simon Praetorius enabled an automatic merge when all merge checks for 70cfdd7a pass

    enabled an automatic merge when all merge checks for 70cfdd7a pass

  • Carsten Gräser canceled the automatic merge

    canceled the automatic merge

  • Carsten Gräser
  • Carsten Gräser
  • Carsten Gräser resolved all threads

    resolved all threads

  • Carsten Gräser enabled an automatic merge when all merge checks for 70cfdd7a pass

    enabled an automatic merge when all merge checks for 70cfdd7a pass

  • mentioned in commit 76e906b8

  • Please register or sign in to reply
    Loading