Replace integerSequenceEntry by get
The utility Dune::integerSequenceEntry
and Dune::IntegerSequenceEntry
are outdated and should be replaced by Dune::get(std::integer_sequence<...>, index)
or Dune::get<index>(std::integer_sequence<...>)
. I have found only one location where it is used. This is fixed already. Note that the class Dune::integerSequenceEntry
is not yet properly replaced, but the Dune::get
utility from integersequence.hh
would also return an std::integral_constant
and thus could be used as replacement.
The old implementation integerSequenceEntry
was by recursion over the index. This could be very time consuming, but on the other hand it could be statically cached by the compiler. So, it is not clear whether this would give a compile-time performance improvement, but at least, the instantiation depth is drastically reduced by the implementation of Dune::get
, which uses an array internally.
Merge request reports
Activity
added cleanup label
- Resolved by Simon Praetorius
requested review from @christi
added 70 commits
-
cb0243c5...b6c3557f - 67 commits from branch
master
- d7d35afc - Replace integerSequenceEntry by get
- b41f1cbc - Add a changelog entry
- 07e1d2dc - Restructure the changelog after rebase
Toggle commit list-
cb0243c5...b6c3557f - 67 commits from branch
added 23 commits
-
07e1d2dc...0298f0f7 - 20 commits from branch
master
- 0cad2c7b - Replace integerSequenceEntry by get
- bb90a0ed - Add a changelog entry
- 3fc5c0ae - Restructure the changelog after rebase
Toggle commit list-
07e1d2dc...0298f0f7 - 20 commits from branch
added 24 commits
-
3fc5c0ae...c8801253 - 21 commits from branch
master
- 73a18c80 - Replace integerSequenceEntry by get
- e6097454 - Add a changelog entry
- 1777aab7 - Restructure the changelog after rebase
Toggle commit list-
3fc5c0ae...c8801253 - 21 commits from branch
added 10 commits
-
1777aab7...d46fc4f1 - 9 commits from branch
master
- 70cfdd7a - Replace integerSequenceEntry by get
-
1777aab7...d46fc4f1 - 9 commits from branch
enabled an automatic merge when all merge checks for 70cfdd7a pass
- Resolved by Carsten Gräser
- Resolved by Carsten Gräser
enabled an automatic merge when all merge checks for 70cfdd7a pass
mentioned in commit 76e906b8