Skip to content
Snippets Groups Projects

More constexpr!

Merged Santiago Ospina De Los Ríos requested to merge feature/more-constexpr into master
All threads resolved!

This MR focuses in FieldVector, FieldMatrix and iterator utilities. In particular, this is a step towards a constexpr reference elements in dune-geometry.

Note that this needs !1388 (closed) to be resolved.

Edited by Santiago Ospina De Los Ríos

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Christoph Grüninger

      I am not convinced that re-implementing basic math stuff is the right approach. Rely on C++23 or even C++26 if you really need constexpr for exceptions and other difficult cases. With other words, guard the constexpr that do not compile with C++20 with feature macros or language macros.

  • added 1 commit

    • 3996dc6c - Throw RangeError exception in bounds check instead of using DUNE_THROW

    Compare with previous version

  • added 69 commits

    • 3996dc6c...fa579ea1 - 66 commits from branch master
    • 1a16e388 - Add more constexpr qualifiers
    • a15dbfd2 - More constexpr: backport constexpr versions of std::abs and std::sqrt
    • cf1b6cb4 - Add integral and floating point constraints

    Compare with previous version

  • added 2 commits

    Compare with previous version

  • mentioned in merge request !1485 (merged)

  • added 1 commit

    Compare with previous version

  • added 41 commits

    • 0b36e315...8b31a737 - 34 commits from branch master
    • 39bca8f4 - Add more constexpr qualifiers
    • ad350c7b - More constexpr: backport constexpr versions of std::abs and std::sqrt
    • a8e061dc - Add integral and floating point constraints
    • 4f282d2a - Move back-port within macro
    • f04e57fb - Format code
    • a641a08b - Use ADL to resolve std abs
    • ce8abde6 - Remove const-eval preprocessor check

    Compare with previous version

  • added 1 commit

    • 96212ee5 - Remove superfluous endif prerpocessor directive

    Compare with previous version

  • changed the description

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Santiago Ospina De Los Ríos marked this merge request as ready

    marked this merge request as ready

  • Santiago Ospina De Los Ríos requested review from @gruenich and removed review request for @simon.praetorius

    requested review from @gruenich and removed review request for @simon.praetorius

  • Christoph Grüninger enabled an automatic merge when all merge checks for f6843fb9 pass

    enabled an automatic merge when all merge checks for f6843fb9 pass

  • Christoph Grüninger canceled the automatic merge

    canceled the automatic merge

  • added 15 commits

    Compare with previous version

  • Christoph Grüninger resolved all threads

    resolved all threads

  • Christoph Grüninger enabled an automatic merge when all merge checks for 00256cb8 pass

    enabled an automatic merge when all merge checks for 00256cb8 pass

  • mentioned in commit 8f1177e4

  • Please register or sign in to reply
    Loading