Skip to content
Snippets Groups Projects

Fix for DiagonalMatrix * OtherMatrix

Merged Simon Praetorius requested to merge fix/diagonalmatrix-matrix-product into master
All threads resolved!

Summary

This MR provides an overload for the matrix-matrix product involving a DiagonalMatrix as first factor. This was not working properly before, if the second factor is a transposed view of a matrix, see #400 (closed).

In addition to the operator* overload for DiagonalMatrix and some other dense matrix, this MR implements the operator[] overload for the TransposedMatrixWrapper in order to implement the matrix-matrix product. If someone has a better idea, please comment.

  • Needs documentation of the new methods.
  • Needs some additional tests of the methods.
  • Needs !1496 (merged)

Closes #400 (closed)

Edited by Simon Praetorius

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Simon Praetorius changed the description

    changed the description

  • Simon Praetorius marked this merge request as draft

    marked this merge request as draft

  • Simon Praetorius marked the checklist item Needs !1496 (merged) as completed

    marked the checklist item Needs !1496 (merged) as completed

  • Simon Praetorius added 92 commits

    added 92 commits

    Compare with previous version

  • Simon Praetorius resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Simon Praetorius marked the checklist item Needs documentation of the new methods. as completed

    marked the checklist item Needs documentation of the new methods. as completed

  • Simon Praetorius added 2 commits

    added 2 commits

    • 24b83bb9 - Add matrix-matrix multiplication with DiagonalMatrix<1>
    • 1ccfedb6 - Add a test of the matrix-matrix multiplication with DiagonalMatrix

    Compare with previous version

  • Simon Praetorius marked the checklist item Needs some additional tests of the methods. as completed

    marked the checklist item Needs some additional tests of the methods. as completed

  • Simon Praetorius marked this merge request as ready

    marked this merge request as ready

  • Carsten Gräser
  • added 1 commit

    • c702e475 - Add some includes of data structures used in the matrix product

    Compare with previous version

  • Simon Praetorius resolved all threads

    resolved all threads

  • Carsten Gräser approved this merge request

    approved this merge request

  • mentioned in commit 3dfe5805

  • Please register or sign in to reply
    Loading