Fix for DiagonalMatrix * OtherMatrix
All threads resolved!
All threads resolved!
Summary
This MR provides an overload for the matrix-matrix product involving a DiagonalMatrix
as first factor. This was not working properly before, if the second factor is a transposed view of a matrix, see #400 (closed).
In addition to the operator*
overload for DiagonalMatrix
and some other dense matrix, this MR implements the operator[]
overload for the TransposedMatrixWrapper
in order to implement the matrix-matrix product. If someone has a better idea, please comment.
-
Needs documentation of the new methods. -
Needs some additional tests of the methods. -
Needs !1496 (merged)
Closes #400 (closed)
Edited by Simon Praetorius
Merge request reports
Activity
added bugfix label
requested review from @carsten.graeser
assigned to @simon.praetorius
mentioned in merge request !1478 (merged)
- Resolved by Simon Praetorius
marked the checklist item Needs !1496 (merged) as completed
added 92 commits
-
edd8fa1a...95b4edaa - 90 commits from branch
master
- b828fc8d - Fix for DiagonalMatrix * OtherMatrix
- c1b7862a - Check whether OtherMatrix is a dense matrix
-
edd8fa1a...95b4edaa - 90 commits from branch
- Resolved by Simon Praetorius
added 1 commit
- c702e475 - Add some includes of data structures used in the matrix product
mentioned in commit 3dfe5805
Please register or sign in to reply