Skip to content
Snippets Groups Projects

Add concept indirectly_copyable to constrain the DenseMatrixAssigner

Merged Simon Praetorius requested to merge feature/dense-matrix-assigner-constraints into master
All threads resolved!

Summary

Add concept definition Std::indirectly_copyable that checks whether the value provided by one iterator can be assigned to the reference provided by a second iterator. This concept is then used to constrain the DenseMatrixAssigner properly. The old constraint was not precise enough and lead to some unintended constructor invocations.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Christoph Grüninger approved this merge request

    approved this merge request

  • Simon Praetorius
  • Note that the indirectly_copyable concept is lacking in libc++-13, which is in our current support-list. It is supported with libc++-15.

  • added 1 commit

    • 3476af35 - Remove check for .N() and .M() in DenseMatrix assigner doe to incomplete type problems

    Compare with previous version

  • added 1 commit

    • 0fcefe96 - Remove check for existence of concepts header

    Compare with previous version

  • Simon Praetorius resolved all threads

    resolved all threads

  • mentioned in commit c8801253

  • Please register or sign in to reply
    Loading