Skip to content
Snippets Groups Projects

[cmake] extract bottom block from config.h.cmake

Merged Tobias Malkmus requested to merge feature/FS1713-add-config_h-bottom-section into master

For dune-grid a bottom section is needed to place the Grid Type magic at the bottom of the config.h file in derived modules.

In this patch a /* begin bottom / ... / end bottom */ block from each module's config.h.cmake file and placed at the end of the collected config.h file.

This resolves the problems from FS#1713 if the same branch is applied in dune-grid.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • :thumbsup: I gave your changes a try, I dunecontrol-all'ed all modules DuMuX is depending from. No fallout with CMake 3.4.

  • Tobias Malkmus Added 10 commits:

    Added 10 commits:

  • @tobias.malkmus I would prefer a rebase (with a forced push) over merging master into the branch. Probably I should start a general discussion about further git best practices.

  • @gruenich i did a manual rebase: new branch + cherry-pick + amend + forced push

  • Is there a reason not to merge this?

  • Martin Nolte mentioned in commit b1e924e6

    mentioned in commit b1e924e6

  • Martin Nolte Status changed to merged

    Status changed to merged

  • mentioned in issue #17 (closed)

  • Martin Nolte mentioned in commit 1605dbb0

    mentioned in commit 1605dbb0

  • Martin Nolte Mentioned in commit b1e924e6

    Mentioned in commit b1e924e6

  • Please register or sign in to reply
    Loading