[cmake][dune_add_test] Remove target dependency of expected to fail tests (!410) · Merge requests · Core Modules / dune-common · GitLab

Snippets Groups Projects

Closed Timo Koch requested to merge tkoch/dune-common:feature/fix-test-depend-on-target-for-expected-to-fail-tests into master 7 years ago

Since commit 27af4005 test depend on their target to correctly state "Not Run" when the target is missing instead of failed. This shouldn't be done for test that are expected to fail compiling though. This patch fixes that.

@joe I noticed a problem with the other fix too. Weirdly the CI didn't complain about this but you can see that the expected-to-fail-compiling tests are marked as "Not Run" now it in the logs. It seems weird that the pipeline still passed.

Activity

Timo Koch @tkoch · 7 years ago

Author Owner

now the pipeline looks as expected again.
Timo Koch mentioned in issue #100 (closed) 7 years ago

mentioned in issue #100 (closed)
Jö Fahlke closed 7 years ago

closed
Jö Fahlke @joe · 7 years ago

Owner

Uh, sorry, I didn't see you already had a fix for this before fixing it myself in !413 (merged).

Please register or sign in to reply