Skip to content
Snippets Groups Projects

[shared_ptrtest.cc] Remove fallback for compilers without nullptr

Merged [shared_ptrtest.cc] Remove fallback for compilers without nullptr
remove-shared-ptr-test-no-nullptr-fallback into master
Merged Jö Fahlke requested to merge remove-shared-ptr-test-no-nullptr-fallback into master

HAVE_NULLPTR is always defined to 1, so the fallback is never reached.

Intend to merge: 2018-04-25

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ansgar Burchardt
    Ansgar Burchardt @ansgar ·
    Owner

    Couldn't most of the test go away? It mostly tests std::shared_ptr...

  • Jö Fahlke
    Jö Fahlke @joe ·
    Author Owner

    Probably. Feel free to extend this MR, or to make your own MR.

    Besides running std::shared_ptr through an exercise course, as far as I can see the test

    • ensures that Dune::shared_ptr is present,
    • ensures that Dune::make_share() is present,
    • attempts to check the explicit-casting version of stackobject_to_shared_ptr(), although that did not trigger when removing that version in !475 (merged). I guess that could be adapted for the non-casting version instead. Also, I'm just noticing that the SHARED_PTR_COMPILE_FAIL-part is never exercised.

    I'm actually wondering why Dune::shared_ptr and Dune::make_shared() aren't deprecated.

  • Jö Fahlke merged

    merged

  • Jö Fahlke mentioned in commit ab175198

    mentioned in commit ab175198

Please register or sign in to reply