Skip to content
Snippets Groups Projects

DuneMPI: append flags to `COMPILE_OPTIONS` instead of `COMPILE_FLAGS`

COMPILE_FLAGS is a string, but set_property(... APPEND ...) appends to a list. If the list of compile flags is not empty this results in a superfluous semicolon in the compile flags which will break the compiler invocation.

For example, when MPI_DUNE_COMPILE_FLAGS=-lpthread, calling add_dune_mpi_flags twice for the same target would result in the compiler command containing -lpthread;-lpthread.

This patch makes use of the COMPILE_OPTIONS property instead which is a list.

Merge request reports

Pipeline #9265 passed

Pipeline passed for 4063acee on ansgar:bugfix/DuneMPI-use-COMPILE_OPTIONS

Approval is optional

Merged by Ansgar BurchardtAnsgar Burchardt 6 years ago (May 29, 2018 12:52pm UTC)

Pipeline #9275 passed

Pipeline passed for 96ed065a on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading