Skip to content
Snippets Groups Projects

Add copy-constructor and copy-assign to VariableSizeCommunicator

This basically implements the rule of 3, as we have a custom destructor. Without this patch, copying a VariableSizeCommunicator will lead to double frees.

This addresses issue #159 (closed). As stated there, an alternative might be to not use MPI_Comm_dup and MPI_Comm_free and thus not assuming any ownership at all. Then, the default constructors etc. are probably just fine.

Merge request reports

Pipeline #19526 passed

Pipeline passed for de905369 on lasse.hinrichsen:feature/variablesizecomm-copy

Approval is optional

Closed by Christoph GrüningerChristoph Grüninger 5 years ago (Dec 19, 2019 10:37pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading