Fix #236

A collection of smaller changes to setup-dunepy.py to fix #236 (closed)

mentioned in issue #236 (closed)

added 1 commit

• 17c39415 - [python] only cmake split argument, if they contain "="

Compare with previous version

mentioned in issue #238 (closed)

Just checked 17c39415 and everything works fine with my setup

added 1 commit

• ead43f11 - [python] store cmake argumets simply as a list

Compare with previous version

added 1 commit

• 5ee6c45d - [python] store cmake argumets simply as a list

Compare with previous version

added 1 commit

• f7085563 - [python] store cmake argumets simply as a list

Compare with previous version

added 1 commit

• 205eac49 - debug info, as I can't reproduce the error at home

Compare with previous version

added 1 commit

• e0b1c0a5 - fix call to shlex.split

Compare with previous version

added 1 commit

• 5fccea67 - [python] store cmake argumets simply as a list

Compare with previous version

@andreas.dedner can you give the current version a try on your setup. I had some problems testing this properly, but it seems to work now.

added 1 commit

• c350155d - add `wheel` to required packages in dune.module

Compare with previous version

Still works for me.

I just noticed something that I would like to fix: the order in which make install_python is called in setup-dunepy does not match dependencies which means that dune-common is not (always) the first where the install is called. It didn't make a difference so far but if we add the pyroject.toml file to have wheel installed (see #239 (closed)) then it would be good to have dune-common first so that this file only needs to be added in dune-common and not in all downstream modules.

Fixing the order seems to be a really good idea.

I didn't notice that the order differs from that of dunecontrol.

Do you want to add it to this MR, or should we merge and create a new MR?

Let's add it here - if I see this correctly then the reason is the 'python's dict order is not deterministic' feature.

added 1 commit

• 85801614 - fix the order in which dune modules are processed when calling `make...

Compare with previous version

The order issue should be fixed now and wheel is also installed before dune.common installation starts

added 1 commit

• 7a4cb489 - change to CMakeLists.txt added by mistake in previous commit

Compare with previous version

added 1 commit

• 15f2151a - catch exception when calling make install_python for an installed module.

Compare with previous version

Are your changes ready to merge? I think it would be good to go on with this MR, as it contains several fixes I need in order to work with/on the python interfaces.

Merging is fine with me

marked this merge request as ready

OK. I removed the WIP and will merge now.

merged

mentioned in commit 9a4f79ad