Skip to content
Snippets Groups Projects

Remove cxx feature checks that are already in c++17 standard library

Merged Simon Praetorius requested to merge feature/reduce-cxx-feature-checks into master
All threads resolved!

Summary

This MR removes some c++ feature checks from cmake, since the features are already standard:

  • DUNE_HAVE_CXX_BOOL_CONSTANT
  • DUNE_HAVE_CXX_EXPERIMENTAL_BOOL_CONSTANT
  • DUNE_HAVE_HEADER_EXPERIMENTAL_TYPE_TRAITS
  • DUNE_HAVE_CXX_APPLY
  • DUNE_HAVE_CXX_EXPERIMENTAL_APPLY
  • HAVE_IS_INDEXABLE_SUPPORT

The fallback implementations are removed and the inclusion into the Dune::Std namespace is marked deprecated. This does typically not work for using declarations. Thus, the functions are marked deprecated in Doxygen only.

Edited by Simon Praetorius

Merge request reports

Pipeline #34525 passed

Pipeline passed for a26d05bd on feature/reduce-cxx-feature-checks

Merged by Simon PraetoriusSimon Praetorius 4 years ago (Mar 8, 2021 8:19pm UTC)

Loading

Pipeline #34574 passed

Pipeline passed for f1bec4e4 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Simon Praetorius resolved all threads

    resolved all threads

  • added 1 commit

    • c6d551b9 - Apply 2 suggestion(s) to 2 file(s)

    Compare with previous version

  • added cleanup label

  • added 1 commit

    • a26d05bd - remove cxx feature checks that are already in c++17 standard library

    Compare with previous version

  • Simon Praetorius resolved all threads

    resolved all threads

  • mentioned in commit f1bec4e4

  • mentioned in issue #199 (closed)

  • mentioned in issue #234 (closed)

  • mentioned in issue #251 (closed)

  • Please register or sign in to reply
    Loading