Feature/fromvertices

see issue #1 (closed)

we move the makeFromVertices implementation into a utility function, which clearly states that it only works up to 3D.

@martin.nolte The build currently fails, as I seem to have misunderstood something about the construction of the topology id. My implementation of a guess of the ID and the ID of the generated GeometryType differ. Could you have a quick look?

Added 1 commit:

• a5ca73e0 - [utility] rename to geometryTypeFromVertexCount

Compare with previous version

Added 2 commits:

• 8ce6e357 - [test] immediately compare the geometry types instead of the IDs
• 5c54a504 - [test] cleanup the output of the fromVertexCount test

Compare with previous version

Added 1 commit:

• 36b10026 - in C++11 and newer, inline is sufficient to enforce weak symbols

Compare with previous version

Resolved all discussions

Unmarked this merge request as a Work In Progress

Status changed to merged

Mentioned in commit b18b7bb9

@christi Do you need this feature in 2.5 (it has the 2.5 milestone assigned)?

We once discussed that the change should be in 2.5, if you consider it too late, skip it. Otherwise it would be good, to cleanup in geometry constructors.

Mentioned in merge request !42 (merged)

Okay, then I would prefer to skip it (and will remove the milestone from the merge request).

I found two minor errors that I fixed in !42 (merged) (but the CI build fails after updating gitlab-ci-multi-runner; need to look at that too).

Mentioned in commit 908b99dd

Mentioned in merge request !43 (merged)

The old function name geometryTypeFromVertices() was still used in some places. I've changed it to geometryTypeFromVertexCount() in !43 (merged).

Mentioned in commit b9e93111

mentioned in issue #1 (closed)