[GeometryType] Clean up storage

This patch removes the packed bitfield used to store both the dimension and the none flag in a single byte. This optimization does not change anything about the size of GeometryType as a whole, because it would be 5 bytes even with the optimization and the C++ ABI (at least on 64-bit platforms) automatically rounds that up to 8 bytes, so we can just as easily let both the flag and the dimension have a full byte of their own.

This also improves the code generated by both GCC and Clang quite a bit. In order to further improve matters, I reordered the member variables and put the topologyId_ variable last.

mentioned in merge request !87 (merged)

This really helps with resolving #17 (closed) (via !87 (merged)), so I'd like to have this in 2.6 if we add the GeometryType::Id support.

mentioned in issue #17 (closed)

What's the status? Can we merge? Shall this go into 2.6 (GeometryType is rather deep down)?

added 1 commit

• 5f2396cd - [GeometryType] Clean up storage

Compare with previous version

resolved all discussions

I remove the spurious line breaks, keeping the coding style. As nobody opposed, I'm going to merge this to master.

@andreas.dedner: Should this go into the release?

enabled an automatic merge when the pipeline for 5f2396cd succeeds

merged

mentioned in commit 1eb68a62