-
- Downloads
[!352] add ctype dependent tolerance to grid tests
Merge branch 'issue/test_tolerances' into 'master' ref:core/dune-grid ### Summary Change the fixed hard coded tolerances in grid tests with something related to numeric_limits<ctype>::epsilon(). ### Details Many tolerances in the grid tests are hard coded to something like 1.e-8. Those tests will fail if ctype=float. Thus, all those comparisons are changed to either sqrt(numeric_limits<ctype>::epsilon()) or numeric_limits<ctype>::epsilon(), depending on the previous value. ### Discussion The tolerance values seem quite arbitrary. Sometimes it is compared against 1.e-8, sometimes 1.e-7 or 1.e-6 or 1e3*numeric_limits<ctype>::epsilon(). Maybe it would be cleaner to use the FloatCmp utilities and clearly define what's the expected accuracy. See merge request [!352] [!352]: gitlab.dune-project.org/core/dune-grid/merge_requests/352
No related branches found
No related tags found
Showing
- dune/grid/test/checkcomcorrectness.hh 4 additions, 3 deletionsdune/grid/test/checkcomcorrectness.hh
- dune/grid/test/checkcommunicate.hh 26 additions, 18 deletionsdune/grid/test/checkcommunicate.hh
- dune/grid/test/checkgeometryinfather.hh 10 additions, 5 deletionsdune/grid/test/checkgeometryinfather.hh
- dune/grid/test/checkintersectionit.hh 13 additions, 11 deletionsdune/grid/test/checkintersectionit.hh
- dune/grid/test/checkjacobians.hh 6 additions, 5 deletionsdune/grid/test/checkjacobians.hh
- dune/grid/test/checktwists.hh 7 additions, 5 deletionsdune/grid/test/checktwists.hh
Loading
Please register or sign in to comment