Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • D dune-grid
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 42
    • Issues 42
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Core Modules
  • dune-grid
  • Merge requests
  • !113

Do not force grids to subclass Entity or Geometry

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Markus Blatt requested to merge do-not-force-grids-to-subclass into releases/2.5 Oct 25, 2016
  • Overview 0
  • Commits 8
  • Pipelines 1
  • Changes 7

The current implementation assumes that both the Entity and the Geometry of a grid are subclasses of Dune::Entity and Dune::Geometry. This requirement must have been introduced after 2.4.1 and is IMHO to much of restriction. After all these are just tests. With this MR we drop this additional restriction. Tested with opm-grid.

Closes #36 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: do-not-force-grids-to-subclass