UGGrid: append to-be-visited sons at the end of the list

Prepending them to the beginning of the list would mean they are never visited as the iterator only moves forward. This required switching to a std::list as the std::forward_list does not provide methods to add items at the end.

This regression was introduced in 20b821be which replaced Dune::SLList with std::forward_list, but changed push_back to push_front as well.

Closes: #53 (closed)

dune/grid/uggrid/uggrid.cc

@@ -410,19 +410,21 @@ void Dune::UGGrid<dim>::getChildrenOfSubface(const typename Traits::template Cod
 
     if (UG_NS<dim>::myLevel(theElement) < maxl) {
 
-      Get_Sons_of_ElementSide(theElement,
-                              side,         // Input element side number
-                              &Sons_of_Side,       // Number of topological sons of the element side
-                              SonList,            // Output elements
-                              SonSides,           // Output element side numbers
-                              true,
-                              true);
+      int rv = Get_Sons_of_ElementSide(theElement,
+                                       side,          // Input element side number
+                                       &Sons_of_Side, // Number of topological sons of the element side
+                                       SonList,       // Output elements
+                                       SonSides,      // Output element side numbers
+                                       true,
+                                       true);
+
+      if (rv != 0)
+        DUNE_THROW(GridError, "Get_Sons_of_ElementSide returned with error value " << rv);
 
       for (int i=0; i<Sons_of_Side; i++)
         list.emplace_back(SonList[i], SonSides[i]);
 
     }
-
   }
 
   // //////////////////////////////