Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • D dune-grid
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 43
    • Issues 43
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Be aware that the dune-project.org domain and its name server will have some updates between February 6, 8:00 UTC (9:00 CET) and 10:00 UTC (11:00 CET) as we will be performing services relocation during this time.

  • Core ModulesCore Modules
  • dune-grid
  • Merge requests
  • !350

Truncate denormalized floating point values to 0 when writing ASCII

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Steffen Müthing requested to merge bug/do-not-crash-paraview-on-macos into master Aug 01, 2019
  • Overview 0
  • Commits 2
  • Pipelines 3
  • Changes 2

Paraview (well, probably VTK) on macOS crashes when reading ASCII files with denormalized float values. This seems to be due to libc++'s IO stream implementation, which sets the fail bit when reading a denormalized value. On top of that, Paraview just segfaults when encountering a fail bit while loading VTK files.

libstdc++ does not set the failt bit, and I don't know what is the correct behavior, but having Paraview mysteriously crash on DUNE output files is not good.

So this patch truncates subnormal floating point values to 0 when writing ASCII. This should not seriously influence any visualization results, but it might trip up people who use exact floating point comparisons for tests (but then you shouldn't do that anyway...).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bug/do-not-crash-paraview-on-macos