Skip to content
Snippets Groups Projects

allow an ε in comparison of grid coordinates

Merged Ansgar Burchardt requested to merge ansgar/dune-grid:i386-tolerance into master

This fixes a test failure on i386 with recent versions of GCC where the numbers looked identical, even when printed with increased precision or in binary (hexfloat) format, for the test-dgf-yasp-offset test:

InvalidStateException [checkEntityLifetimeForCodim:.../dune-grid-2.6.0/dune/grid/test/checkentitylifetime.hh:77]:
ERROR! inconsistent corner(0) coordinate for entity 27
  (0 0.30000000000000004 != 0 0.30000000000000004)
  (0x0p+0 0x1.3333333333334p-2 != 0x0p+0 0x1.3333333333334p-2)

But the test still failed as i386's x87 FPU uses a higher precision internally.

Reference: https://buildd.debian.org/status/fetch.php?pkg=dune-grid&arch=i386&ver=2.6.0-4&stamp=1570661057&raw=0

Merge request reports

Pipeline #21761 passed

Pipeline passed for eff46396 on ansgar:i386-tolerance

Approval is optional

Merged by Ansgar BurchardtAnsgar Burchardt 5 years ago (Oct 13, 2019 1:13pm UTC)

Merge details

  • Changes merged into master with dd5d30f7.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #21762 passed

Pipeline passed for dd5d30f7 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading