Skip to content
Snippets Groups Projects

[feature][GridView] added isConforming method

Merged Robert K requested to merge feature/gridview-isconforming into master
1 unresolved thread

with fallback to GridView::conforming.

Merge request reports

Pipeline #43755 passed

Pipeline passed for 9fbdb641 on feature/gridview-isconforming

Merged by Robert KRobert K 2 years ago (Mar 10, 2022 5:32pm UTC)

Loading

Pipeline #43925 passed

Pipeline passed for f273fbdf on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
324 339 return DeprecatedMethodEmptyFuture();
325 340 }
326 341
342 template <class M>
  • Robert K added 3 commits

    added 3 commits

    • 2b7cb378 - [feature][GridView] added isConforming method with fallback to
    • 818bcee8 - [feature][tests] Added test for GridView::isConforming.
    • 9e60b461 - [feature][Grids] Implement a isConforming method for grids where it is

    Compare with previous version

  • This is ready from my side. The deprecation works, I get it with ALUGrid now and for YaspGrid and OnedGrid, AlbertaGrid the new method is implemented. For UGGrid somebody else has to at some point make an implementation. This should be done in a separate MR.

  • Resolves #139 (closed).

    Edited by Robert K
  • Thanks for implementing this feature. Can you please add a description and the new requirements for grid implementors in the changelog?

  • Robert K added 1 commit

    added 1 commit

    • 9fbdb641 - [docu] Added changelog entry for isConforming.

    Compare with previous version

  • Robert K mentioned in commit f273fbdf

    mentioned in commit f273fbdf

  • merged

  • Robert K mentioned in issue #139 (closed)

    mentioned in issue #139 (closed)

  • Please register or sign in to reply
    Loading