Skip to content
Snippets Groups Projects

Add missing isNone if statement in checkintersectionit.hh

All threads resolved!

Currently at link, the refIntNormal object is only populated, if isNone() is false.

Then this is caught at several later places but not at link.

Therefore, this MR also wraps this call with an if statement.

This was found by @henrik.jakob.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alexander Müller resolved all threads

    resolved all threads

  • added 1 commit

    • ed374726 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    • 06ade1c7 - Add missing isNone if statement in checkintersectionit.hh

    Compare with previous version

  • Thanks for your reviews! I think this is ready now. I applied the suggested changed and squashed the two commits.

  • Do you mind rebasing? Then I am going to merge.

  • added 5 commits

    Compare with previous version

  • mentioned in commit d23fb225

  • removed review request for @oliver.sander

  • Christoph Grüninger resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading