Skip to content
Snippets Groups Projects

Implement subIndex for 3D edges and corners

Open Implement subIndex for 3D edges and corners
feature/uggrid-subindex into master
All threads resolved!
Open Santiago Ospina De Los Ríos requested to merge feature/uggrid-subindex into master
All threads resolved!

With @oliver.sander we sat down to provide all the possible results of subIndex for UGGrid. In particular:

  • 3D entities for volume, edge and line may ask for a sub-entity index embedded in its geometry in any (sub-)codim.
  • Additionally, it fixes a bug for codim==0 subIndex of an edge: If the an 3D edge is passed as an argument requesting a 0 sub-codim index, the previous implementation would try to get the index of the 0-th vertex, rather than of the edge itself.

Close #155

Edited by Santiago Ospina De Los Ríos

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Santiago Ospina De Los Ríos added 26 commits

    added 26 commits

    Compare with previous version

    Toggle commit list
  • Santiago Ospina De Los Ríos added 1 commit

    added 1 commit

    • faf5cc06 - Add renumbering of sub-indices

    Compare with previous version

  • Oliver Sander added 1 commit

    added 1 commit

    • e13b19c0 - UGGridRenumberer: Add faceEdgeDUNEtoUG and faceVertexDUNEtoUG

    Compare with previous version

  • Santiago Ospina De Los Ríos added 3 commits

    added 3 commits

    • 00ba697c - Fix ordering of pyramids in star-cd
    • 73585cde - Use side type directly
    • 7977d778 - Check for correct number of sub indices

    Compare with previous version

  • Santiago Ospina De Los Ríos
  • Santiago Ospina De Los Ríos added 1 commit

    added 1 commit

    Compare with previous version

  • Santiago Ospina De Los Ríos marked this merge request as ready

    marked this merge request as ready

  • Santiago Ospina De Los Ríos changed the description

    changed the description

  • Santiago Ospina De Los Ríos resolved all threads

    resolved all threads

  • Santiago Ospina De Los Ríos
    Santiago Ospina De Los Ríos @santiago.ospina ·
    Author Owner

    @oliver.sander should we squash and merge this? From what we could test, this seems to be now the right implementation. Or do you have any other suggestion?

  • Santiago Ospina De Los Ríos assigned to @santiago.ospina

    assigned to @santiago.ospina

  • Santiago Ospina De Los Ríos requested review from @oliver.sander

    requested review from @oliver.sander

    • Please register or sign in to reply