Feature/fs1721 grid selector

See flyspray/FS#1721 (closed)

allow to enable/disable the gridselector feature.

Added 276 commits:

• 66ff5e20...085adb4b - 275 commits from branch master
• bad34d12 - [feature][cmake] make grid selection in config.h optional (default is off).

Added 3 commits:

• c552de95 - restructure the dgf tests to not rely on GridSelector, as it is now optional
• 1c7bc4b1 - rename test-dgf.cc to checkdgf.hh
• 8175a29d - don't use GridSelector for test-geogrid

Looks familiar. I remember I did something like this some time ago but then I never followed up on it. What is the status here?

Se set this up, based on your old feature branch. I asked for responses. I think if nobody complains we can merge next week. After adapting some dune-grid test, dune-grid now doesn't rely on the GridSelector any mroe, so that it should be safe to merge. I also don't see any compatibility issues, as the feature is there, it is just optional.

I tested this branch and it's not really working except for basically disabling the GridSelector feature. The things I implemented back in the day were based on an older version of the cmake system. That's easy to fix and I try to do this until the end of this week. I'll report back when I think it's ready for a merge.

great! I basically only made sure that the tests still work, if the GridSelector is disabled. I didn't check what happens if it is enabled, assuming that your patch still works.

Added 1 commit:

• 29b031bd - [bugfix] Make GridSelector optional and work with current cmake build system.

Milestone changed to %DUNE 2.5.0

What is the status. Did anyone look at this. Can I merge this?

Added 42 commits:

• 29b031bd...f7bf5805 - 37 commits from branch master
• be984921 - [feature][cmake] make grid selection in config.h optional (default is off).
• db13e2bc - restructure the dgf tests to not rely on GridSelector, as it is now optional
• e7512acb - rename test-dgf.cc to checkdgf.hh
• 485e81f2 - don't use GridSelector for test-geogrid
• 634191e5 - [bugfix] Make GridSelector optional and work with current cmake build system.

Rebased on on of master.

@robert.kloefkorn the status is that you wanted so cleanup some issues. Is this done? Should someone test it out?

PS: I'm very much in favor if merging this soon.

It's good to go from my point of view.

Added 15 commits:

• 634191e5...7b79d628 - 10 commits from branch master
• fa1cb084 - [feature][cmake] make grid selection in config.h optional (default is off).
• f5703304 - restructure the dgf tests to not rely on GridSelector, as it is now optional
• edd1dfca - rename test-dgf.cc to checkdgf.hh
• 0752dcc7 - don't use GridSelector for test-geogrid
• b202e5a8 - [bugfix] Make GridSelector optional and work with current cmake build system.

Compare with previous version

Mentioned in commit ecdc1a43

Status changed to merged

Mentioned in commit 31fc54b5

Mentioned in merge request !123 (merged)

Mentioned in commit 57877ad1