Skip to content
Snippets Groups Projects
Commit d487fef6 authored by Markus Blatt's avatar Markus Blatt
Browse files

Merge branch 'feature/remove-forbidden-downcast' into 'master'

Remove forbidden downcast

This removes several constructors and assignments from base class in the class hierarchy around `base_array`. These removed methods are all implemented using a downcast which may result in undefined behaviour.
Since they are not used anywhere in the core modules we can maybe remove them. According to @markus.blatt  these base classes are all meant to be internal.

This may cause problems if user code explicitly uses the raw base classes and these methods. However, such user code would only be valid if the passed base class reference is actually an upcasted derived class which is very unlikely.

See merge request !66
parents 3119e52b b797918e
No related branches found
No related tags found
1 merge request!66Remove forbidden downcast
Pipeline #
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment