Skip to content
Snippets Groups Projects
  1. Jun 02, 2024
  2. Jan 27, 2024
  3. Jan 26, 2024
  4. Jan 18, 2024
  5. Sep 19, 2023
  6. May 25, 2023
  7. Apr 11, 2023
  8. Jan 08, 2023
  9. Dec 02, 2022
  10. Nov 16, 2022
  11. Sep 30, 2022
  12. Sep 29, 2022
  13. Feb 28, 2022
  14. Jan 20, 2022
  15. Jan 06, 2022
  16. Dec 17, 2021
  17. Dec 09, 2021
  18. Dec 06, 2021
  19. Nov 26, 2021
  20. Nov 10, 2021
  21. Sep 28, 2021
  22. Aug 13, 2021
  23. Jul 07, 2021
  24. Jun 30, 2021
  25. Feb 07, 2021
  26. Jan 17, 2021
  27. Jan 10, 2021
  28. Jan 08, 2021
  29. Apr 11, 2020
  30. Apr 03, 2020
  31. Mar 29, 2020
    • Oliver Sander's avatar
      Rewrite doc of the BCRSMatrix 'implicit' build mode · a1feed88
      Oliver Sander authored
      Circumstances forced me to finally learn what the BCRSMatrix 'implicit'
      build mode really does, and where its limitations come from.  I had
      to read the code for that.  As it turns out, the documentation of the
      mode is quite misleading.  My main gripe is that the code uses two
      different auxiliary data structures, but the documentation calls them
      both 'overflow'.  This problem even extends to the variable naming
      in the code.  Behold: the parameter 'overflowsize' is NOT the size
      of the member 'overflow'.  It doesn't even have anything to do with
      that member...
      
      To improve the situation, this patch does three things:
      a) It rewrites the documentation.  In particular, the 'overflow area'
         is now clearly distinguished from the 'compression buffer'.
         The latter is a new word I introduce.
      b) It renames the BCRSMatrix method parameter _overflowsize to
         compressionBufferSize, because that is what it is:  That parameter
         has nothing to do with the 'overflow' data member, or even the
         concept of 'overflowing' in general.
      c) It renames the exception 'ImplicitModeOverflowExhausted' to
         'ImplicitModeCompressionBufferExhausted', for the same reason.
         This is the only interface changes.  The code keeps the old
         exception for backward-compatibility, but makes it trigger a
         deprecation warning.
      a1feed88
Loading