Marco Agnese authored 10 years ago and Christoph Grüninger committed 9 years ago

Signed-off-by: Christoph Grüninger <gruenich@dune-project.org>

Marco Agnese authored 10 years ago and Christoph Grüninger committed 9 years ago

Cherry-picked changes, left out white-space changes,
from 857fdd91dcea7af2ab5f1c1147a59a187cb253db
and 8c21e316e4b72b38972b0c1a93254171566979c6

Signed-off-by: Christoph Grüninger <gruenich@dune-project.org>

Marco Agnese authored 10 years ago and Christoph Grüninger committed 9 years ago

Signed-off-by: Christoph Grüninger <gruenich@dune-project.org>

Marco Agnese authored 10 years ago and Christoph Grüninger committed 9 years ago

Signed-off-by: Christoph Grüninger <gruenich@dune-project.org>

Marco Agnese authored 10 years ago and Christoph Grüninger committed 9 years ago

Signed-off-by: Christoph Grüninger <gruenich@dune-project.org>

Marco Agnese authored 10 years ago and Christoph Grüninger committed 9 years ago

Cherry-picked changes, left out white-space changes
and variable renaming, from 36cebfb6d30703a9db4253e4ca4f7d7f3b4e92d3

Signed-off-by: Christoph Grüninger <gruenich@dune-project.org>

Fix Wshadow warnings

As always, please add your wishes for alternative renaming of variable names.

See merge request !16

In particular, getting rid of the German comment is necessary because my venerable ddd
debugger frontend chokes on umlauts.

The BCRSMatrix code clearly shows that you have to call endrowsizes before calling
addindex.  Therefore the third way to build a BCRSMatrix in the 'random' way is wrong
and should be removed from the test.

Use constexpr instead of DUNE_CONSTEXPR



See merge request !18

Feature/smaller cleanups

as the title suggests, these are a couple of smaller fixes, which are not directly related and aren't important enough to manage them in separate branches.

See merge request !13

we introduced a template Parameter for the type counting the current
iteration. In general this is an int, but e.g. the BiCGStab print also
the intermediate steps, thus it uses double as CountType. As Markus
pointed out, the original name Int was not very intuitive.

The information has been provided by the MatrixDimensions struct since roughly the end of 2010.
Correspondingly, the methods rowdim and coldim have been removed from the istl matrix implementations.
Apparently, we forgot to remove them from the Matrix class.

MultiTypeBlockVector: Fix NaN behaviour of infinity_norm()

As a follow-up to flyspray/FS#1147, in response to dd7e8ed3, this makes `MultiTypeBlockVector::infinity_norm()` `NaN`-aware: In analogy to previous patches for other matrix/vector classes, this patch turns `infinity_norm` into two functions; a straight-forward version for `field_type`s that do not have `NaN` values and a less efficient version for ones that do.

It should be noted, however, that because `field_type` is currently hard-coded to be `double` in `MultiTypeBlockVector`, the `NaN`-aware version will, as long as this is so, always be used.

See merge request !15

[bugfix] fix broken assertion.

This patch fixes the errornous commits
e8d16384
1a2f4d0f

The introduced range checks were plain wring, as they neglected the nested structure of the
BlockVector. We now use `b.dim()` to get the flat size.

This fixes flyspray/FS#1724.

See merge request !12

this feature is necessary to keep readable output if we use funny value types, like Vc::double_v

This patch fixes the errornous commits
e8d16384
1a2f4d0f

The introduced range checks were plain wring, as they neglected the nested structure of the
BlockVector. We now use `b.dim()` to get the flat size.

This fixes flyspray/FS#1724.

Test complex<T> for floating point T only

The issue that I originally filed for dune-common as flyspray/FS#1726 affects dune-istl, too.

See merge request !11

The standard leaves (the effect of instantiating) complex<T> for more
general T unspecified.

flyspray/FS#1147: Fix NaN behaviour of infinity_norm() for istl classes

This is an extension of the work related to flyspray/FS#1147 to dune-istl.

See merge request !10

This includes the behaviour of its rows, thus the
CompressedBlockVectorWindow class