Skip to content
Snippets Groups Projects

Fix test assumption that the CreateIterator of VariableBlockVector is a forward iterator

Closed Steffen Müthing requested to merge bugfix/fix-iterator-type-of-createiterator into master

The CreateIterator of VariableBlockVector is currently an output iterator. This creates problems with the tests, which use std::fill() with those iterators, and that function actually requires forward iterators (because output iterators are not comparable). The libc++ implementation of clang 7 actually enforces this, causing test failures.

Looking at the implementation, making the iterator a forward iterator seems more trouble than it's worth, so fix the test.

Edited by Steffen Müthing

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading