Cleanup the VariableBlockVector implementation

Summary

Cleanup the implementation of VariableBlockVector using std::vector for memory management. Rebased version of !253 (closed).

Closes !253 (closed)

• Requires dune-common!1366 (merged) to be merged
• Should include !563 (merged)
• Should be based on !564 (merged)

approved this merge request

Too bad. Does not compile with gcc11. @lasse.hinrichsen do you mind taking another look.

I almost forgot about this one. With regards to gcc 11, I can have a look, but maybe not this week (or year?).

While this is an old MR, I think it should be revisited and finished. The proposed changes are good.

mentioned in merge request !253 (closed)

added 206 commits

• 6ae7c785...7e400e26 - 201 commits from branch master
• 09c5e632 - [VariableBlockVector] Use std::vector for memory management
• ef2d9df2 - [VariableBlockVector] Fix beforeBegin iterator
• 0bec5711 - [VariableBlockVector] Move constructor and assignment
• 7a8b9b90 - [VariableBlockVector] Fix typo in comment
• 770d798e - Use the IndexedIterator and the copy-and-swap ideom

Compare with previous version

resolved all threads

added 1 commit

• 7526db3a - Cleanup the constructors

Compare with previous version

The cleanup is continued. And I have rebased to the current master. There are a few improvements still possible, e.g. unified naming, proper documentation. Some design patters are also not good style (e.g. the CreateIterator, since it performs a possibly throwing allocation operation in its destructor) but the change would be out of the scope of this MR.

requested review from @markus.blatt

changed the description

added 10 commits

• 7526db3a...b9726dcf - 4 commits from branch master
• 97d5ea8c - [VariableBlockVector] Use std::vector for memory management
• d7f14c88 - [VariableBlockVector] Fix beforeBegin iterator
• b658aa38 - [VariableBlockVector] Move constructor and assignment
• 0090aee9 - [VariableBlockVector] Fix typo in comment
• 9a5efb47 - Use the IndexedIterator and the copy-and-swap ideom
• 600a1a84 - Cleanup the constructors

Compare with previous version

marked the checklist item Requires dune-common!1366 (merged) to be merged as completed

marked the checklist item Should include !563 (merged) as completed

marked the checklist item Should include !563 (merged) as incomplete

marked the checklist item Should include !563 (merged) as completed

changed the description

resolved all threads

added 9 commits

• 600a1a84...d87a2b8b - 3 commits from branch master
• 9f8b9184 - [VariableBlockVector] Use std::vector for memory management
• 70f90ad8 - [VariableBlockVector] Fix beforeBegin iterator
• d73b15dd - [VariableBlockVector] Move constructor and assignment
• a157324a - [VariableBlockVector] Fix typo in comment
• 8ffc42cb - Use the IndexedIterator and the copy-and-swap ideom
• 383b531a - Cleanup the constructors

Compare with previous version

marked the checklist item Should be based on !564 (merged) as completed

changed title from Cleanup/use std vector for vbv data (rebased) to Cleanup the VariableBlockVector implementation

changed the description

This is ready for merge. Any objections?

resolved all threads

changed the description

added 9 commits

• 383b531a...20bcffa6 - 2 commits from branch master
• a3fc1acf - [VariableBlockVector] Use std::vector for memory management
• 0b118727 - [VariableBlockVector] Fix beforeBegin iterator
• 684137fb - [VariableBlockVector] Move constructor and assignment
• aaf15e8c - [VariableBlockVector] Fix typo in comment
• d8bfdea1 - Use the IndexedIterator and the copy-and-swap ideom
• 8f647bae - Cleanup the constructors
• 56a905fb - Add error message for VariableBlockVector<bool>

Compare with previous version

added 1 commit

• aa421035 - Add changelog entry

Compare with previous version

added 12 commits

• aa421035...f37f90ae - 4 commits from branch master
• aab39c5a - [VariableBlockVector] Use std::vector for memory management
• 1efccb40 - [VariableBlockVector] Fix beforeBegin iterator
• 2383e8e3 - [VariableBlockVector] Move constructor and assignment
• 6d05b85d - [VariableBlockVector] Fix typo in comment
• b2fdc57a - Use the IndexedIterator and the copy-and-swap ideom
• b34fb142 - Cleanup the constructors
• bbc28728 - Add error message for VariableBlockVector<bool>
• d8f9e4c2 - Add changelog entry

Compare with previous version

enabled an automatic merge when the pipeline for d8f9e4c2 succeeds

mentioned in commit f05ed2b5

merged