Feature/base array bounds checking
This is an attempt to further unify bounds checking in DUNE. This is a controversial change and it's not unlikely that it will be rejected.
The questions that it raises and which need to be addressed:
- Is it okay to replace
DUNE_ISTL_WITH_CHECKING
withDUNE_CHECK_BOUNDS
and aISTLError
with aRangeError
or do we need a transition solution here with a deprecation period? - Since this would be the first use of
DUNE_CHECK_BOUNDS
for a class that's not a matrix or vector: Is it appropriate to useDUNE_CHECK_BOUNDS
here or does this go beyond its intended scope (which is to say: what is its intended scope?)? @markus.blatt has already made it clear that he would preferNDEBUG
in this particular case (the second change); maybe we can find a general guideline. - (worth mentioning) Both before and after this change, the error message contains additional information (an index) in some places but not others.
Merge request reports
Activity
Filter activity
Please register or sign in to reply