Skip to content
Snippets Groups Projects

Feature/base array bounds checking

Open Feature/base array bounds checking
feature/base-array-bounds-checking into master
Open Elias Pipping requested to merge feature/base-array-bounds-checking into master

This is an attempt to further unify bounds checking in DUNE. This is a controversial change and it's not unlikely that it will be rejected.

The questions that it raises and which need to be addressed:

  • Is it okay to replace DUNE_ISTL_WITH_CHECKING with DUNE_CHECK_BOUNDS and a ISTLError with a RangeError or do we need a transition solution here with a deprecation period?
  • Since this would be the first use of DUNE_CHECK_BOUNDS for a class that's not a matrix or vector: Is it appropriate to use DUNE_CHECK_BOUNDS here or does this go beyond its intended scope (which is to say: what is its intended scope?)? @markus.blatt has already made it clear that he would prefer NDEBUG in this particular case (the second change); maybe we can find a general guideline.
  • (worth mentioning) Both before and after this change, the error message contains additional information (an index) in some places but not others.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply