Feature/base array bounds checking
This is an attempt to further unify bounds checking in DUNE. This is a controversial change and it's not unlikely that it will be rejected.
The questions that it raises and which need to be addressed:
- Is it okay to replace
DUNE_ISTL_WITH_CHECKINGwithDUNE_CHECK_BOUNDSand aISTLErrorwith aRangeErroror do we need a transition solution here with a deprecation period? - Since this would be the first use of
DUNE_CHECK_BOUNDSfor a class that's not a matrix or vector: Is it appropriate to useDUNE_CHECK_BOUNDShere or does this go beyond its intended scope (which is to say: what is its intended scope?)? @markus.blatt has already made it clear that he would preferNDEBUGin this particular case (the second change); maybe we can find a general guideline. - (worth mentioning) Both before and after this change, the error message contains additional information (an index) in some places but not others.