Skip to content

Reverse dataset shape when building interpolator in scaling adapter

Lukas Riedel requested to merge fix-interpolator-dataset-shape into master

What does this MR do?

Reverse the shape of a dataset before it is inserted into the interpolator used in a scaling adapter.

Why was this MR needed?

Non-square and non-cubic datasets were strangely distorted when inserted as scaling fields.

The bug is a regression from a recent change in H5File where the shape returned by read_dataset is not reversed anymore, but the same as in the actual H5 file.

Is there something that needs to be double checked?

  • [ ] Do we need to update a unit test to check if datasets with non-square shapes are used correctly? No. But: tests for scaling fields should be updated through !122 (merged)
  • @hbauser, can you confirm this fixes your issue?

Can this MR be accepted?

  • Implemented bug fix
  • Pipeline passing
  • Added entry to CHANGELOG.md

Related issues

None

Edited by Lukas Riedel

Merge request reports