Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • D dune-grid-glue
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 9
    • Issues 9
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • extensions
  • dune-grid-glue
  • Merge requests
  • !48

Increase the minimal cmake version and link only against dependent packages

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Simon Praetorius requested to merge issue/update-cmakelists into master Sep 07, 2021
  • Overview 8
  • Commits 1
  • Pipelines 1
  • Changes 2

Summary

When configuring dune-grid-glue in combination with dune modules that require cmake 3.13, the old cmake_minimal_requires(VERSION 2.8.x) might cause hard to find errors in cmake, since this version requirements actually changes the behavior of cmake.

The examples are linked against all dune libraries by using target_link_dune_default_libraries. This might cause problems with alberta-grid that is not used, but raises a linker error, see #20. This MR fixes this by only linking against dunegrid.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: issue/update-cmakelists