Increase the minimal cmake version and link only against dependent packages
1 unresolved thread
1 unresolved thread
Compare changes
Files
2+ 1
− 1
When configuring dune-grid-glue in combination with dune modules that require cmake 3.13, the old cmake_minimal_requires(VERSION 2.8.x)
might cause hard to find errors in cmake, since this version requirements actually changes the behavior of cmake.
The examples are linked against all dune libraries by using target_link_dune_default_libraries
. This might cause problems with alberta-grid that is not used, but raises a linker error, see #20. This MR fixes this by only linking against dunegrid
.
Why only dunegrid? dune-grid-glue should also use stuff from at least dunecommon (MPIHelper).
And what about the tests?
This recursively links against dune-common as well
The tests are implemented with
dune_add_test
. This does something different internally. It links against libraries only explicitly when requested but also enables all flags, e.g. callsadd_dune_alberta_flags
that performs the full linkage against alberta-grid and thus no undefined symbols should remain.Is dune-grid-glue supposed to work with dune < 2.7 as well? Then maybe this line needs to be changed to something backwards compatible:
I don't think that that's necessary.
We should simply tag the last 2.6 compatible version.
Is the current master still compatible with 2.6?
Either way, I would like to just call the current state 2.8.0 (with changes to .gitlab-ci.yml on the release branch).
Ansgar, go ahead! We can tag the last 2.6-compatible version whenever somebody asks for it.