Skip to content
Snippets Groups Projects

[examples] Fix matrix/vector types of examples

Merged Carsten Gräser requested to merge cleanup/fix-example-types into master

The nested matrix and vector types should correspond to the index tree of the basis. Here, this is not the case since Field*<T,*> was used instead of T. While this is in many cases no problem, it may fail if the matrix is recursively traversed with IsNumber as termination criterion.

Merge request reports

Pipeline #76492 passed

Pipeline passed for 5e9faaed on cleanup/fix-example-types

Approval is optional

Merged by Carsten GräserCarsten Gräser 2 months ago (Feb 1, 2025 2:22am UTC)

Merge details

  • Changes merged into master with fe543f9c.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #76493 passed

Pipeline passed for fe543f9c on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • While it is not obvious, this is the first of a sequence of changes towards getting rid of the old basis implementations.

    • Before removing the old bases we should have hanging node support for the new ones.
    • With hanging nodes the old utility for incorporating Dirichlet values no longer works and has to be replaced by a generic matrix traversal algorithm.
    • Generic matrix traversal requires the matrix nesting structure and multi-index type match.
  • Carsten Gräser enabled an automatic merge when all merge checks for 5e9faaed pass

    enabled an automatic merge when all merge checks for 5e9faaed pass

  • mentioned in commit fe543f9c

Please register or sign in to reply
Loading