Skip to content
Snippets Groups Projects
Oliver Sander's avatar
commented on merge request !214 "[draft] Feature/use dune assemblers" at fufem / dune-fufem

I agree that dune-assembler should eventually the global assemblers that we have in dune-fufem. That could even happen right now as far as I am co...

Carsten Gräser's avatar
commented on merge request !214 "[draft] Feature/use dune assemblers" at fufem / dune-fufem

As discussed, maintaining support for three dune versions and three combinations of assembler frameworks in dune-fufem is IMO far to much work. If ...

Oliver Sander's avatar
commented on merge request !214 "[draft] Feature/use dune assemblers" at fufem / dune-fufem

Can I ask about the status here? What needs to be done before this can be merged?

Carsten Gräser's avatar
pushed to branch master at fufem / dune-fufem
  • e787bd25 · [doc] Reduce sidebar width
Carsten Gräser's avatar
Carsten Gräser's avatar
pushed to branch master at fufem / dune-fufem
Oliver Sander's avatar
deleted branch add-spdx-headers at fufem / dune-fufem
Oliver Sander's avatar
accepted merge request !275 "Add spdx headers" at fufem / dune-fufem
Oliver Sander's avatar
pushed to branch master at fufem / dune-fufem
Carsten Gräser's avatar
commented on merge request !275 "Add spdx headers" at fufem / dune-fufem

And finally I documented the license in the doxygen pages. IMO this MR is now ready.

Carsten Gräser's avatar
pushed to branch add-spdx-headers at fufem / dune-fufem
Carsten Gräser's avatar
commented on merge request !275 "Add spdx headers" at fufem / dune-fufem

I rebased and collected changes into a single commits per used license, attributing the one for the dune license to @oliver.sander since you did mo...

Carsten Gräser's avatar
pushed to branch add-spdx-headers at fufem / dune-fufem
Oliver Sander's avatar
commented on merge request !275 "Add spdx headers" at fufem / dune-fufem

Okay!

Carsten Gräser's avatar
commented on merge request !275 "Add spdx headers" at fufem / dune-fufem

I changed the remaining occurrences of see file LICENSE.md... to see file AUTHORS.md. Now this seems to be done. Before merging I suggest to stash ...

Oliver Sander's avatar
approved merge request !275 "Add spdx headers" at fufem / dune-fufem
Carsten Gräser's avatar
commented on merge request !275 "Add spdx headers" at fufem / dune-fufem

Implemented.

Carsten Gräser's avatar
pushed to branch add-spdx-headers at fufem / dune-fufem
  • e8ef61ee · Refer to AUTHORS.md in SPDX headers
Carsten Gräser's avatar
pushed to branch add-spdx-headers at fufem / dune-fufem
  • 12631139 · Switch to 'DUNE-FUFEM Project contributors' in SPDX header
Oliver Sander's avatar
commented on merge request !275 "Add spdx headers" at fufem / dune-fufem

Yes, why not. But it doesn't seem very important to me either: The 'truth' is AUTHORS.md anyway.