And fix all spelling errors that codespell currently finds.

See https://reuse.software/ for a description.

With SuperLU 5.0 version macros are provided.

Call find_path, find_library only one due to changed semantics
Drop undocumented SUPERLU_PREFIX and SUPERLU_ROOT, CMake uses
SuperLU_ROOT by default now.

dune-common does no longer require / look for Fortran,
so the condition would be always false.

Only SuperLU 5 is now supported.

Explicitly linking the BLAS library is only needed when static
linking, but not when using a shared library version of SuperLU.  In
the latter case the development files for BLAS might not even be
installed and therefore we should not require them here.

Otherwise it cannot be found

This patch gets rid of the compiler warnings generated by the antiquated ARPACK sources by turning
the ARPACK include directory into a system include directories. Compilers don't generate warnings
for code in system include directories, so this is a blanket solution for all kinds of problems in
this source (that we treat as upstream and thus can't fix anyway).

depending on a preprocessor define we switch the base classes to be
pure virtual, or implement a dummy category(). If the classes are pure
virtual the old interface with an enum is not possible anymore.

To enable/disable the backwards compatibility check we provide a cmake
flag DUNE_ISTL_SUPPORT_OLD_CATEGORY_INTERFACE, which defaults to 1
(e.g. backwards compatibility enabled).

Markus Blatt authored 8 years ago and Christoph Grüninger committed 8 years ago

Previously, we only supported one numeric type (float, double, complex<float>,
or complex<double>) that the user could select via a cryptic preprocessor
define. This was done this way because when including SuperLU headers we
would otherwise have multiply defined structs in SuperLU. At least in 4.3
GlobalLU_t is defined in slu_sdefs.h, slu_ddefs.h, slu_cdefs.h, and
slu_zdefs.h

With this commit we do not include the problematic SuperLU headers anymore.
Instead why define the functions called by us with extern C within DUNE.
In addition we now provide all the numeric types for which SuperLU drivers are
found at the same time.

Hopefully this will also fix problems with multiply defined BLAS routines experienced
with arpack and SuperLU.

Previously CMake pretended to have found a valid
SuperLU version for DUNE even if the version was
too old (i.e. < 4). People having such an old versions
only noticed this via later compile errors of binaries
using SuperLU. That is far too late.

With this patch we introduce a compile check into the
CMake module that fails for old unsupported versions.
In that case CMake will not find SuperLU.

* Use correct macro
* adjust changes for other types then double, too

Arne Morten Kvarving authored 8 years ago and Christoph Grüninger committed 8 years ago

API for solver routine changed. Since there is no versioning
in SuperLU we have to do a probe to detect the new library.

Don't end configure if BLAS is not found. Only the SuperLU
test should fail, which will be the case anyway.

Use proper C macros for LDL and SPQR.

Let FindPackageHandleStandardArgs handle missing dependencies.
Mark ARPACKPP_LIBRARY as advanced.
Remove dead code.