FS#1512 Replace type traits by their standard versions

See core/dune-common!27 (closed) for more information.

mentioned in issue flyspray/FS#1512 (closed)

Thanks for the rather tedious work! Please take a look at my comment above and run the test suite on the changes, thanks!

Reassigned to @smuething

Milestone changed to PDELab 3.0.0

Added 18 commits:

• 4bc58694...f7679491 - 10 commits from branch pdelab:master
• 8f92dc7a - [cleanup] replace IsBaseOf with std::is_base_of
• 01ee7c88 - [cleanup] use is_same from std::
• e12e003a - [cleanup] use enable_if from std::
• 67ce1d94 - [cleanup] use conditional from std::
• 4c5c69eb - [cleanup] use is_base_of from std::
• 413e7576 - [cleanup] use integral_constant from std::
• a01b00d9 - [cleanup] use remove_const from std::
• 92000334 - [cleanup] use true_type and false_type from std::

I've fixed the above typo and tried to compile the test suite. Unfortunately, I only got 51% through building the test suite, as testcomplexnumbers-istl didn't compile since I don't have SuperLU. The exact error message was

/home/data/gruber/src/dune-experiments/dune-pdelab/dune/pdelab/test/testcomplexnumbers.cc: In function ‘void helmholtz_Qk(const GV&, PARAM&)’:
/home/data/gruber/src/dune-experiments/dune-pdelab/dune/pdelab/test/testcomplexnumbers.cc:187:3: error: ‘SuperLU’ is not a member of ‘Dune’
   Dune::SuperLU<ISTLM> superlu(native(m), 1);
   ^

but I think this belongs into a new bug report.

@smuething, can you try to compile the whole test suite on your side?

I have fixed that problem in !117 (merged)

Thanks @dominic, that was quick!

With the fix from !117 (merged), the test suite compiles with my type traits changes.

And the tests also run without failure now.

@felix.gruber make -k does not break after a build failure, would have helped in your case, too.

Good to know! That will definitely be useful for another time.

Looks good now, thanks!

Status changed to merged

mentioned in commit cc5cf09e