Skip to content

Fix entity set handling

Steffen Müthing requested to merge feature/fix-entity-set-handling into master

When fixing the way EntitySets are handled in GridFunctionSpaces, Andreas took away the possibility to pass an EntitySet to the constructor of the space. That is problematic for two reasons:

  1. The EntitySet is the actual entity being used here, and it's an ideal place to cache all kinds of information not provided by the underlying GridView, so I want this thing to be available.
  2. Speaking of efficiency, for non-overlapping computations the IndexSet contained in the EntitySet is a non-trivial object and we don't want to create a gazillion copies of it.

So this merge requests reverts the solution from !192 (merged) (but keeps the tests) and goes for a much simpler solution: By default, an EntitySet will now initialize upon construction and will contain index information for all codimensions. This is basically free in the default case of a AllPartition, and if you are running non-overlapping, you will have to take care of correctly initializing the EntitySet anyway.

This fixes #62 (closed), #70 (closed) and #78 (closed).

Merge request reports