Remove redundant include of `test-localfe.hh` in gridviewfunctionspacebasistest.cc
To my understanding, this include is a remnant of a previous implementation.
Merge request reports
Activity
enabled an automatic merge when the pipeline for 5a13befd succeeds
enabled an automatic merge when the pipeline for 5a13befd succeeds
added 1 commit
- 88f4565e - Remove `disabledLocalTests` in gridviewfunctionspacebasistest.cc as it was not used.
added 1 commit
- c669083c - Remove redundant DisableLocalInterpolation Symbol.
mentioned in merge request !481
I am not sure, because I am not sure what the purpose of this file is. If it is meant to just test the cases currently implemented, I would say the symbols from localfunctions are redundant. If this is meant to be a general implementation then I think the functionality code should be refactored, extended by tests for partial(), a test for the Duality of interpolation and shapefunctions, and readied for Hermite-like or vector/tensor valued finite elements, and moved to
dune/functions/functionspacebases/test/basistest.hh
.I am also not sure if I like that this file depends on a localfunctions test which is not part of their official API. Additionally, 'localfunctions/test/test-localfe.hh' defines FiniteElementFunctions which are not conforming the dune-functions GridViewFunction interface. Admittedly, the latter is true for my MR !481 too.
Edited by Maik Porrmann
mentioned in commit ccc00ea4