Skip to content
Snippets Groups Projects
Oliver Sander's avatar
deleted branch make-flat-indices-the-default at staging / dune-functions
Oliver Sander's avatar
pushed to branch master at staging / dune-functions
Oliver Sander's avatar
accepted merge request !530 "Inform users of pending change of default index merging strategies" at staging / dune-functions
Carsten Gräser's avatar
commented on merge request !530 "Inform users of pending change of default index merging strategies" at staging / dune-functions

Go ahead.

Simon Praetorius's avatar
approved merge request !530 "Inform users of pending change of default index merging strategies" at staging / dune-functions
Oliver Sander's avatar
commented on merge request !530 "Inform users of pending change of default index merging strategies" at staging / dune-functions

The CI is fixed now (it was only a timeout). Are there further objections to merging this?

Simon Praetorius's avatar
commented on merge request !529 "[DRAFT] relax consistency guarantees." at staging / dune-functions

Could we also add these "guarantees" somewhere into the documentation of the interface? E.g. into the documentation of the finiteElement() method. ...

Carsten Gräser's avatar
commented on merge request !529 "[DRAFT] relax consistency guarantees." at staging / dune-functions

Since the method describes if calling finiteElement() is OK, hasFiniteElement() seems to be reasonable.

Oliver Sander's avatar
closed merge request !456 "[python] Use the same default index merging strategies as C++" at staging / dune-functions
Oliver Sander's avatar
commented on merge request !456 "[python] Use the same default index merging strategies as C++" at staging / dune-functions

Superseded by !530 (merged).

Oliver Sander's avatar
commented on merge request !530 "Inform users of pending change of default index merging strategies" at staging / dune-functions

I tested the Python changes now, and they work as they should.

Oliver Sander's avatar
pushed to branch make-flat-indices-the-default at staging / dune-functions
  • e618b291 · Inform Python users of pending change of default 'layout' parameter
Oliver Sander's avatar
pushed to branch make-flat-indices-the-default at staging / dune-functions
  • a36eedf0 · Inform Python users of pending change of default 'layout' parameter
Christian Engwer's avatar
commented on merge request !531 "Cast size_type indices on composite nodes to a common index type" at staging / dune-functions

As far as I recall (but this is long ago...) the decision was on the interface. Apparently it was not sufficiently documented and not represented i...

Santiago Ospina De Los Ríos's avatar
commented on merge request !531 "Cast size_type indices on composite nodes to a common index type" at staging / dune-functions

Ah, I remember that. But that was for TypeTree::HybridTreePath, which is different to the multi-index value type....

Simon Praetorius's avatar
commented on merge request !531 "Cast size_type indices on composite nodes to a common index type" at staging / dune-functions

We had the discussion about the tree-path indices to make them size_t. The prebases implementations simply define size_type=std::size_t in all our ...

Santiago Ospina De Los Ríos's avatar
commented on merge request !531 "Cast size_type indices on composite nodes to a common index type" at staging / dune-functions

I was probably not during the discussion. Is this about the implementation or the interface?...

Oliver Sander's avatar
commented on merge request !530 "Inform users of pending change of default index merging strategies" at staging / dune-functions

Changed as requested. Still 'draft' because I didn't have time to actually test the Python changes yet.

Oliver Sander's avatar
pushed to branch make-flat-indices-the-default at staging / dune-functions
Carsten Gräser's avatar
commented on merge request !531 "Cast size_type indices on composite nodes to a common index type" at staging / dune-functions

As far as I remember, we did.