[bugfix] Fix bisection loadbalancing algorithm

ebf74cbf replaces three sort functions by a template. However, the template arguments were never used in the function, so we only sorted in one coordinate direction. This commit fixes this by replacing the hard-coded indices with the template argument values.

Thanks to Leopold Stadler for finding the offending commit.

• Should be backported to the release/2.7 branch.

Fixes #51 (closed)

@leopold.stadler can you try this?

It works now for my test (rectangular domain).

mentioned in issue #51 (closed)

changed the description

@tkoch , @leopold.stadler , thanks for finding and fixing this!

added 1 commit

• 105df623 - [bugfix] Fix bisection loadbalancing algorithm

Compare with previous version

resolved all threads

As @tkoch is currently working on a full rewrite of the load balancing code, I would suggest to merge this fix and add a regression test with a known partition. This will help avoiding new errors in the transition phase.

A unit test would be nice. I wasn't sure how to do test this nicely though. I could use a rectangular grid then it should be possible to predict the partitions simply by coordinates and the number of processors. But for unstructured grids I have no idea.

BTW, I consider !151 (merged) finished for now. But I just verified that it works by looking at a parallel UG test in Dumux.

I think a structured grid with a given process could would be enough.

mentioned in merge request core/dune-grid!372 (closed)

added test in core/dune-grid!372 (closed) but this has to be merged first otherwise the test fails.

mentioned in merge request core/dune-grid!373 (merged)

mentioned in commit 3865fe02

merged

mentioned in commit 36e641a5