Feature/refactor recursive coordinate bisection lb

• Use more descriptive variables names and comments
• Use some descriptive helper functions
• Reduce code duplication
• Improve sorting efficiency by using only a partial sort with std::nth_element
• Define variables in local scope
• Remove doc clutter

changed the description

added 1 commit

• 7d35fb3c - [lbrcb] Use FieldVector for element center. Replace some macros.

Compare with previous version

mentioned in merge request !149 (merged)

resolved all threads

changed the description

added 3 commits

• ba898a38 - [lbrcb] Use lambda for sorting and proper epsilon for floating point comparison
• 047ffcc0 - [lbrcb] Add comment about bisection strategy
• 14350254 - [lbrcb] Use FieldVector for element center. Replace some macros.

Compare with previous version

mentioned in merge request core/dune-grid!373 (merged)

added 28 commits

• 14350254...3865fe02 - 5 commits from branch staging:master
• 1294e948 - [lbrcb] Give function descriptive name theRCB -> recursiveCoordinateBisection
• f48a0bc5 - [lbrcb] Change signature to return void. Error handling via return code was never done anyway.
• c35a96ee - [lbrcb] Actually throw an exception if this is used for distributed grids
• 3ca6b434 - [lbrcb] Remove redundant documentation clutter
• bc1df5d9 - [lbrcb] Limit scope of epsilon. Replace macro by constexpr variable.
• baca82c9 - [lbrcb] Limit scope of local variables
• 7d245092 - [lbrcb] Use array as pos storage and .data() to call legay macros
• b3cef19d - [lbrcb] Limit scope of local variables
• 0868d81d - [lbrcb] Change macro indent to clearly mark debug code
• fc3e2c19 - [lbrcb] Remove completely redundant comments. The code says exactly that.
• 3f7d0835 - [lbrcb] Give bisection axis variable a descriptive name
• 3199be56 - [lbrcb] Throw exception instead of aborting
• 099370bf - [lbrcb] Use iterators instead of pointer and size
• 6d2bfd6f - [lbrcb] Be efficient. We only need a partial sort here.
• 013436ce - [lbrcb] Use local variable to improve readability
• 896758e9 - [lbrcb] Fix indent
• cad33fd7 - [lbrcb] Use explanatory comments and variable name
• 88b5647e - [lbrcb] Fix documentation
• d3aac02d - [lbrcb] Use helper functions for processor bisection and represent proc partition as array
• fcbd526d - [lbrcb] Add assert and improve comment
• 026e4d22 - [lbrcb] Use lambda for sorting and proper epsilon for floating point comparison
• 545df0e5 - [lbrcb] Add comment about bisection strategy
• 852796fa - [lbrcb] Use FieldVector for element center. Replace some macros.

Compare with previous version

There is now a unit test for the default bisection in dune-grid (core/dune-grid!373 (merged))

done from my side

Thanks, Timo!

merged

mentioned in commit 08a983bf