Skip to content
Snippets Groups Projects
  1. Feb 26, 2020
  2. Feb 17, 2020
    • Jö Fahlke's avatar
      [!775] SIMD test: fix implicit this capture warnings · 207d6bb5
      Jö Fahlke authored
      Merge branch 'fix-implicit-this-capture' into 'master'
      
      ref:core/dune-common C++20 deprecates implicit capture of this using [=], and
      gcc9 warns about that. Unfortunately, in C++ before 20 listing this together
      with a capture-default of = is illegal, and GCC 8 emits a warning about that
      that apparently can't be silenced. So the only option if we want to appease
      both pre- and post-C++20 is to list each entity to be captures explicitly.
      Luckily, that is not too hard in this case.
      
      See [https://gitlab.dune-project.org/core/dune-common/-/jobs/139584\#L486]
      (debian:11 gcc-9-20):
      
          [ 40%] Building CXX object dune/common/CMakeFiles/dunecommon.dir/simd/test.cc.o
          In file included from /builds/core/dune-common/dune/common/simd/test.cc:6:
          /builds/core/dune-common/dune/common/simd/test.hh: In lambda function:
          /builds/core/dune-common/dune/common/simd/test.hh:334:36: warning: implicit capture of 'this' via '[=]' is deprecated in C++20 [-Wdeprecated]
            334 |         Hybrid::forEach(Rebinds{}, [=](auto target) {
                |                                    ^
          /builds/core/dune-common/dune/common/simd/test.hh:334:36: note: add explicit 'this' or '*this' capture
      
      WIP:
      
      -   [x] Check these warnings are really gone in the CI
      
      See merge request [core/dune-common!775]
      
        [https://gitlab.dune-project.org/core/dune-common/-/jobs/139584\#L486]: https://gitlab.dune-project.org/core/dune-common/-/jobs/139584#L486
        [core/dune-common!775]: gitlab.dune-project.org/core/dune-common/merge_requests/775
      207d6bb5
    • Jö Fahlke's avatar
      SIMD test: fix implicit this capture warnings · 5a14116e
      Jö Fahlke authored
      C++20 deprecates implicit capture of `this` using `[=]`, and gcc9 warns about
      that.  Unfortunately, in C++ before 20 listing `this` together with a
      capture-default of `=` is illegal, and GCC 8 emits a warning about that that
      apparently can't be silenced.  So the only option if we want to appease both
      pre- and post-C++20 is to list each entity to be captures explicitly.
      Luckily, that is not too hard in this case.
      
      See https://gitlab.dune-project.org/core/dune-common/-/jobs/139584#L486
      (debian:11 gcc-9-20):
      ```
      [ 40%] Building CXX object dune/common/CMakeFiles/dunecommon.dir/simd/test.cc.o
      In file included from /builds/core/dune-common/dune/common/simd/test.cc:6:
      /builds/core/dune-common/dune/common/simd/test.hh: In lambda function:
      /builds/core/dune-common/dune/common/simd/test.hh:334:36: warning: implicit capture of 'this' via '[=]' is deprecated in C++20 [-Wdeprecated]
        334 |         Hybrid::forEach(Rebinds{}, [=](auto target) {
            |                                    ^
      /builds/core/dune-common/dune/common/simd/test.hh:334:36: note: add explicit 'this' or '*this' capture
      ```
      5a14116e
    • Jö Fahlke's avatar
      [!773] Fix warnings, add comments in fvectorconversion1d.cc test · 504bd2d4
      Jö Fahlke authored
      Merge branch 'fix-warning-add-comments' into 'master'
      
      ref:core/dune-common This is a regression test, the threw up undefined
      variable warnings. unsure about the correct fix, I tried to understand the
      test. In addition to fixing the warnings, I left some comments too, in the
      hope future readers will have a little easier time understanding what it is
      supposed to do.
      
      The warnings showed up in
      [https://gitlab.dune-project.org/core/dune-common/-/jobs/139437\#L665]
      (debian:10 clang-7-libcpp-17):
      
          [ 60%] Building CXX object dune/common/test/CMakeFiles/fvectorconversion1d.dir/fvectorconversion1d.cc.o
          /builds/core/dune-common/dune/common/test/fvectorconversion1d.cc:86:16: warning: unused variable 'mfv' [-Wunused-variable]
                MiddleFV mfv;
                         ^
          /builds/core/dune-common/dune/common/test/fvectorconversion1d.cc:107:16: warning: unused variable 'mfv' [-Wunused-variable]
                MiddleFV mfv;
                         ^
          2 warnings generated.
      
      See also: [!735], [!562]
      
      See merge request [core/dune-common!773]
      
        [https://gitlab.dune-project.org/core/dune-common/-/jobs/139437\#L665]: https://gitlab.dune-project.org/core/dune-common/-/jobs/139437#L665
        [!735]: gitlab.dune-project.org/NoneNone/merge_requests/735
        [!562]: gitlab.dune-project.org/NoneNone/merge_requests/562
        [core/dune-common!773]: gitlab.dune-project.org/core/dune-common/merge_requests/773
      504bd2d4
    • Jö Fahlke's avatar
      Fix warnings, add comments in fvectorconversion1d.cc test · 1802c531
      Jö Fahlke authored
      This is a regression test, the threw up undefined variable warnings.  unsure
      about the correct fix, I tried to understand the test.  In addition to fixing
      the warnings, I left some comments too, in the hope future readers will have a
      little easier time understanding what it is supposed to do.
      
      The warnings showed up in
      https://gitlab.dune-project.org/core/dune-common/-/jobs/139437#L665 (debian:10
      clang-7-libcpp-17):
      ```
      [ 60%] Building CXX object dune/common/test/CMakeFiles/fvectorconversion1d.dir/fvectorconversion1d.cc.o
      /builds/core/dune-common/dune/common/test/fvectorconversion1d.cc:86:16: warning: unused variable 'mfv' [-Wunused-variable]
            MiddleFV mfv;
                     ^
      /builds/core/dune-common/dune/common/test/fvectorconversion1d.cc:107:16: warning: unused variable 'mfv' [-Wunused-variable]
            MiddleFV mfv;
                     ^
      2 warnings generated.
      ```
      
      See also: !735, !562
      1802c531
  3. Feb 16, 2020
  4. Feb 15, 2020
  5. Feb 13, 2020
  6. Feb 12, 2020
  7. Feb 06, 2020
    • Markus Blatt's avatar
      [!761] [cmake] Use actual build program for Fortran test · 2332bf4a
      Markus Blatt authored
      Merge branch 'feature/support-manually-set-ninja-in-fortran-test' into 'master'
      
      ref:core/dune-common Prior to this change the build program (make, Ninja) was
      not identical to the one used by CMake, but the one installed on the system.
      
      I found this when testing Fortran support of upcoming CMake 3.17 with upcoming
      Ninja 1.10 - which works!
      
      See merge request [core/dune-common!761]
      
        [core/dune-common!761]: gitlab.dune-project.org/core/dune-common/merge_requests/761
      2332bf4a
  8. Jan 30, 2020
  9. Jan 26, 2020
  10. Jan 23, 2020
  11. Jan 21, 2020
    • Ansgar Burchardt's avatar
      [!758] fix C++20 and GCC 10 issues · a9fbe94d
      Ansgar Burchardt authored
      Merge branch 'gcc10' into 'master'
      
      See merge request [core/dune-common!758]
      
        [core/dune-common!758]: Nonecore/dune-common/merge_requests/758
      a9fbe94d
    • Ansgar Burchardt's avatar
      [GCC 10] do not test SIMD with wide character types · 98e4122a
      Ansgar Burchardt authored
      GCC 10's libstdc++ deleted some `operator<<` overloads to write wide
      characters to non-wide streams as these would be treated as integers
      instead of characters. One could use wide variants `wstringstream`,
      `wstring` instead of the usual `stringstream`, `string`, but at some
      places would have to convert between different character
      representations.
      
      As wide characters really should only be used for text, DUNE doesn't
      really need to support them as numerical types here. So we just drop
      the tests using wide character types.
      
      This addresses compiler errors like
      ```
      ../dune/common/simd/test.hh:1732:20: error: use of deleted function ‘std::basic_ostream<char, _Traits>& std::operator<<(std::basic_ostream<char, _Traits>&, wchar_t) [with _Traits = std::char_traits<char>]’
      In file included from /usr/include/c++/10/iostream:39,
                       from ../dune/common/simd/test.hh:12,
                       from dune/common/simd/test/standardtest_vector_wchar_t.cc:5:
      /usr/include/c++/10/ostream:538:5: note: declared here
        538 |     operator<<(basic_ostream<char, _Traits>&, wchar_t) = delete;
      ```
      98e4122a
    • Ansgar Burchardt's avatar
      [C++20] use `std::allocator_traits` · b65b1e2c
      Ansgar Burchardt authored
      Several members of `std::allocator` were already deprecated in C++17
      and have now been removed in C++20. This patch uses the appropriate
      members of `std::allocator_traits` instead.
      b65b1e2c
    • Simon Praetorius's avatar
  12. Jan 19, 2020
  13. Jan 17, 2020
  14. Jan 10, 2020
  15. Jan 08, 2020
Loading