Skip to content
Snippets Groups Projects
Commit 840b4194 authored by Andreas Dedner's avatar Andreas Dedner
Browse files

[!801] [python][generator] Use the alias that is already defined

Merge branch 'feature/python-generator-use-type-alias' into 'master'

ref:core/dune-common\> In the generated code there will be a typedef created
that is marked with DUNE_UNUSED because it is unused. This MR improves
readability of the generated code and makes DUNE_UNUSED obsolete at the same
time.

-   changes the typedef to an alias
-   uses the alias in the actual insertClass class
-   removes the now obsolete dune/common/unused.hh include

See merge request [!801]

  [!801]: gitlab.dune-project.org/core/dune-common/merge_requests/801
parents 5a0db24a cc3bee28
No related branches found
No related tags found
1 merge request!801[python][generator] Use the alias that is already defined
Pipeline #26935 passed
......@@ -34,7 +34,6 @@ class SimpleGenerator(object):
def pre(self, includes, duneType, moduleName, defines=None, preamble=None):
if defines is None: defines = []
source = '#include <config.h>\n\n'
source += "#include <dune/common/unused.hh>\n\n"
source += '#define USING_DUNE_PYTHON 1\n\n'
source += ''.join(["#define " + d + "\n" for d in defines])
source += ''.join(["#include <" + i + ">\n" for i in includes])
......@@ -75,7 +74,7 @@ class SimpleGenerator(object):
source += ' pybind11::module cls0 = module;\n'
source += ' {\n'
source += " typedef " + duneType + " DuneType DUNE_UNUSED;\n"
source += " using DuneType = " + duneType + ";\n"
for i, bc in enumerate(baseClasses):
source += ' Dune::Python::insertClass' +\
'< ' + bc + ' >' +\
......@@ -85,7 +84,7 @@ class SimpleGenerator(object):
");\n"
options.append(bc)
source += ' auto cls = Dune::Python::insertClass' +\
'< ' + duneType +\
'< DuneType' +\
', '.join([""]+options) + ' >' +\
'( cls0, "' + self.typeName[nr] + '"' +\
','.join(['']+clsParams) +\
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment