Skip to content
Snippets Groups Projects

Draft: Try to remove portalocker dependency.

Closed Robert K requested to merge feature/no-portalocker into master
2 unresolved threads

In my opinion portalocker should not be a hard dependency, maybe optional. The reasons is that, there are no system packages, for example, in gentoo, a distro where Python is a central part. So I don't want DUNE to depend on packages that are that far away from the mainstream. This MR was to test what the impact would be. I think there is no major impact.

Edited by Robert K

Merge request reports

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
12 ## This is still needed! Do not remove it.
13 import os
14 import fcntl
15 from fcntl import LOCK_EX, LOCK_SH
16 # file locking from fcntl
17 def lock_file(f, cmd=fcntl.LOCK_EX):
18 fcntl.flock(f, cmd)
19 return f
20 def unlock_file(f):
21 fcntl.flock(f, fcntl.LOCK_UN)
22 return f
1 import os
2 import fcntl
3 from fcntl import LOCK_EX, LOCK_SH
4 # file locking from fcntl
5 def lock_file(f, cmd=fcntl.LOCK_EX):
  • Robert K added 6 commits

    added 6 commits

    Compare with previous version

  • added python label

  • What do we do here? Perhaps a short description at the top what the issue with the current setup is would be helpful.

  • In my opinion portalocker should not be a dependency, maybe optional. The reasons is that, there are no system packages, for example, in gentoo, a distro where Python is a central part. So I don't want DUNE to depend on packages that are that far of the mainstream. This MR was to test what the impact would be. I think there is no major impact.

    Edited by Robert K
  • Moreover, I have been using the whole DUNE Python tool chain without portalocker and without any problems.

  • Robert K changed the description

    changed the description

  • Robert K changed the description

    changed the description

  • Robert K added 66 commits

    added 66 commits

    Compare with previous version

  • This MR seems stale. DUNE is working fine without portalocker, if not found. Reopen if still of interest.

  • closed

  • Please register or sign in to reply
    Loading