Draft: Try to remove portalocker dependency.
In my opinion portalocker
should not be a hard dependency, maybe optional. The reasons is that, there are no system packages, for example, in gentoo, a distro where Python is a central part. So I don't want DUNE to depend on packages that are that far away from the mainstream. This MR was to test what the impact would be. I think there is no major impact.
Merge request reports
Activity
There have been CI failures without
portalocker
some time ago so I suggest that the nightly build should be tested with this: https://gitlab.dune-project.org/infrastructure/dune-nightly-test/-/pipelinesrun pipeline
and setCI_BUILD_REF_NAME
variable to this branch name.
mentioned in merge request !1063 (merged)
12 ## This is still needed! Do not remove it. 13 import os 14 import fcntl 15 from fcntl import LOCK_EX, LOCK_SH 16 # file locking from fcntl 17 def lock_file(f, cmd=fcntl.LOCK_EX): 18 fcntl.flock(f, cmd) 19 return f 20 def unlock_file(f): 21 fcntl.flock(f, fcntl.LOCK_UN) 22 return f 1 import os 2 import fcntl 3 from fcntl import LOCK_EX, LOCK_SH 4 # file locking from fcntl 5 def lock_file(f, cmd=fcntl.LOCK_EX): added 6 commits
-
3bfa6475...9c0f2fd7 - 5 commits from branch
master
- 855c1137 - [cleanup][Python] Remove portalocker dependency.
-
3bfa6475...9c0f2fd7 - 5 commits from branch
added python label
In my opinion
portalocker
should not be a dependency, maybe optional. The reasons is that, there are no system packages, for example, in gentoo, a distro where Python is a central part. So I don't want DUNE to depend on packages that are that far of the mainstream. This MR was to test what the impact would be. I think there is no major impact.Edited by Robert Kadded 66 commits
-
855c1137...5fed5787 - 65 commits from branch
master
- 6299a3b5 - [cleanup][Python] Remove portalocker dependency.
-
855c1137...5fed5787 - 65 commits from branch